calvin.erfmann/pangolin
1
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-01-28 22:00:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

remove device code ip check and fix edit resource dialog state issue

Browse Source
This commit is contained in:
miloschwartz
2025-12-05 11:47:59 -05:00
parent 1cae815be5
commit 8726a7f931
3 changed files with 27 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
server/routers/auth/pollDeviceWebAuth.ts
View File

@@ -125,16 +125,6 @@ export async function pollDeviceWebAuth(
});
}
// Check if IP matches
if (!requestIp || !deviceCode.ip || requestIp !== deviceCode.ip) {
return next(
createHttpError(
HttpCode.FORBIDDEN,
"IP address does not match"
)
);
}
// Check if userId is set (should be set when verified)
if (!deviceCode.userId) {
logger.error("Device code is verified but userId is missing", { codeId: deviceCode.codeId });

2
src/components/ClientResourcesTable.tsx
View File

@@ -226,7 +226,7 @@ export default function ClientResourcesTable({
displayText={resourceRow.alias}
/>
) : (
<span>"-"</span>
<span>-</span>
);
}
},

31
src/components/EditInternalResourceDialog.tsx
View File

@@ -348,17 +348,38 @@ export default function EditInternalResourceDialog({
}
};
// Set form values only once after initial load
const hasInitialized = useRef(false);
const previousResourceId = useRef<number | null>(null);
useEffect(() => {
if (!loadingRolesUsers && !hasInitialized.current) {
if (open) {
const resourceChanged = previousResourceId.current !== resource.id;
if (resourceChanged) {
form.reset({
name: resource.name,
mode: resource.mode || "host",
destination: resource.destination || "",
alias: resource.alias ?? null,
roles: [],
users: [],
clients: []
});
previousResourceId.current = resource.id;
}
hasInitialized.current = false;
}
}, [open, resource.id, resource.name, resource.mode, resource.destination, resource.alias, form]);
useEffect(() => {
if (open && !loadingRolesUsers && !hasInitialized.current) {
hasInitialized.current = true;
form.setValue("roles", formRoles);
form.setValue("users", formUsers);
form.setValue("clients", existingClients);
}
}, [loadingRolesUsers, formRoles, formUsers, existingClients, form]);
}, [open, loadingRolesUsers, formRoles, formUsers, existingClients, form]);
return (
<Credenza
@@ -378,8 +399,8 @@ export default function EditInternalResourceDialog({
users: [],
clients: []
});
// Reset initialization flag so form can re-initialize with fresh data when reopened
hasInitialized.current = false;
// Reset previous resource ID to ensure clean state on next open
previousResourceId.current = null;
}
setOpen(open);
}}