* refactor: minor simplification
* refactor: split open_library into new and not new case
Functionality is entirely unchanged, but entire method is duplicated.
Removing dead code from either copy is next.
* refactor: remove dead code
* doc: add todos and remove trivially true assert
* refactor: add assurance 1 version check
Assurance 1 was introduced with library version 101, specifically commmit 12e074b71d.
Thus all libraries created on version 101 and above already fullfill it and don't need it.
Furthermore, it only fails if the library didn't need the assurance, meaning the try-except and warning catching can be removed
* refactor: remove various unnecessary try-except statements in new_lib
All of these were introduced to account for the differences between new libraries and existing ones,
which makes them unnecessary after this split.
* refactor: remove unnecessary check in new_lib
* refactor: move folder assurance after migrations
The folder assurance has been present since the very first SQL commit e5e7b8afc6,
and thus only has an effect when the library is moved, meaning that is semantically not part of the migrations.
* refactor: massively simplify open_library
* refactor: move engine creation to static method
* refactor: add version check for assurance 3
Assurance 3 was introduced in commit 47c3d5338f
shortly (24h 20min) after the DB version had been bumped to 200.
Since it was also included in the first release with DB version 200,
all libraries created on DB version 200 and above
can be presumed to have already had this applied on creation.
* refactor: add assurance 3 to DB 200 migration
* refactor: move assurance 1 to a proper migration method
Moving the assurance after the migrations 7, 8, 9, and 100 is fine because it doesn't affect those.
* refactor: update version after every successfull migration
Since every migration migrates the library to a certain DB_VERSION, we can simply update the library version after such a successfull migration.
This way if a migration fails, the previous migrations won't be rerun the next time the library is opened.
* refactor: rewrite migration procedure as loop
* refactor: apply migration and update version in same transaction
None of the content of the migrations is changed, only the `with session:` statements are removed.
* refactor: replace all commits in the migrations with flushes
Also removes various try-except statements in the migrations.
These were introduced to catch the case where the migration is run twice due to a later migration failing,
this is not necessary anymore as every migration will only be executed at most once per library.
* refactor: make sure the migration log statements are consistent
* fix: pass library dir to migrations
* fix(db migration 8): only add colors that are actually new
DB Migration 8 was previously adding all colors except for the neon ones,
however, all but three of those have been around since DB version 4,
meaning that they don't need to be added at all (which caused the tests to fail).
* fix: json migration used outdated interface
* fix(open_library): create TS directory only if not opened in memory
* fix: enable sane transaction behaviour
By default in SQLAlchemy schema changes are automatically committed,
even if auto-commit is turned off.
This commit turns off auto-commit completely,
which caused some schema to not be applied correctly,
but those were fixed here as well.
* refactor: hide 'argument is not accessed' notices
* fix(db migration 9): filename property wasn't written correctly
* fix(db migration 104): include/exclude list was loaded incorrectly
* feat: log start and end of DB migrations
* fix: don't use double transaction in open_sqlite_library
* fix: only commit once when creating new library
* doc: add comment on removing Folder logic
* refactor: remove dunder naming
* chore(ci): move spec-file into scripts
* feat(ci)!: rework workflows and build processes
All Python setups route through one local action, and checks are much
more conditional. There is more to be done, but this is a significant
improvement in processing time and redundancy.
As well, nightly builds are made (though not made as GitHub releases..
yet).
* ci: remove symlinked CHANGELONG.md from build_docs.yml paths
* docs: update location of tagstudio.spec
* ci: enforce single quotes in github yaml files
* ci(tests): remove macOS pytest runner
---------
Co-authored-by: Travis Abendshien <46939827+CyanVoxel@users.noreply.github.com>
Definition: https://packaging.python.org/en/latest/specifications/dependency-groups
The optional dependency table ([project.optional-dependencies]) is
supposed to be user-facing for installs of TagStudio. Meanwhile, the
replacement dependency groups is explicitly meant for extra development
tools, so lets use that.
This does mean the command for a full development environment has changed
from:
```sh
pip install -e '.[dev]'
```
To:
```sh
pip install -e . --group all
```
The documentation has been adjusted for a quick replacement, but
probably should have more information on a later time.
* fix/refactor: use generic ModuleStatus class for getting status of optional modules
* fix: add and order macOS bin locations by PATH precedence
* ui: add title for optional modules section in the about window
* fix: revert errant license change
* fix: return which(cmd) instead of the original cmd
* refactor: implement review feedback
* feat(ui): add tooltips for module locations on about screen
* feat(ui): organize settings into new panels
* fix: typo
* fix(ui): add localization for setting panels
* fix(ui): move language to localization panel
* fix: remove invalid child_id relationships from tag_parents
* fix: use single statements in DB 102 & 202 migrations
* fix: remove unnecessary session.scalars() from migrations
* fix: faulty progress bar
The progress bar UI element always showed 1 step ahead of what it supposed to, also causing the last step to display a visual glitch (empty window)
* fix: corrected drop import progress bar text
* fix: corrected relink progress bar
Update progress bar at the beginning of the relink iteration instead of the end, which previously showed incorrect progress text and an empty window during the first iteration.
* fix: corrected 'refresh ignore entries' progress bar
Update progress bar at the beginning of the refresh loop iteration instead of the end, which previously showed incorrect progress text and an empty window during the first iteration.
* fix: corrected 'refresh unlinked' progress bar
Update progress bar at the beginning of the refresh loop iteration instead of the end, which previously showed incorrect progress text and an empty window during the first iteration.
* fix: corrected 'mirror entries' progress bar
Same as last commit
* fix: Unknown key in 'mirror entries' progress bar text (translation formatting)
* fix: corrected 'merge duplicates' progress bar
Note: Seems like this bar is never used in the UI. But if it is in the future, this fixes it just like the other progress bars.
Jann Stute
Jann Stute
Xarvex
purpletennisball
Weblate (bot)
Travis Abendshien
Sola-ris
Xarvex
TheBobBobs
Andreas Heglingegård
Ludvig Sandh