calvin.erfmann/TagStudio
1
0
Fork 0
mirror of https://github.com/TagStudioDev/TagStudio.git synced 2026-01-28 22:01:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: when deleting tag remove all TagParent rows with it's id (#1250)

Browse Source 
* fix: when deleting tag remove all TagParent rows with it's id

* delete TagEntry rows as well
This commit is contained in:
TheBobBobs
2026-01-18 22:53:40 +00:00
committed by GitHub
parent 86274efeef
commit dd01c7cdcd
1 changed files with 12 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
src/tagstudio/core/library/alchemy/library.py
View File

@@ -1170,35 +1170,29 @@ class Library:
session.commit()
return True
def remove_tag(self, tag_id: int):
def remove_tag(self, tag_id: int) -> bool:
with Session(self.engine, expire_on_commit=False) as session:
try:
aliases = session.scalars(select(TagAlias).where(TagAlias.tag_id == tag_id))
for alias in aliases:
session.delete(alias)
session.flush()
tag_parents = session.scalars(
select(TagParent).where(TagParent.parent_id == tag_id)
).all()
for tag_parent in tag_parents:
session.delete(tag_parent)
session.flush()
disam_stmt = (
session.execute(delete(TagAlias).where(TagAlias.tag_id == tag_id))
session.execute(delete(TagEntry).where(TagEntry.tag_id == tag_id))
session.execute(
delete(TagParent).where(
or_(TagParent.child_id == tag_id, TagParent.parent_id == tag_id)
)
)
session.execute(
update(Tag)
.where(Tag.disambiguation_id == tag_id)
.values(disambiguation_id=None)
)
session.execute(disam_stmt)
session.flush()
session.query(Tag).filter_by(id=tag_id).delete()
session.execute(delete(Tag).where(Tag.id == tag_id))
session.commit()
except IntegrityError as e:
logger.error(e)
session.rollback()
return False
return True
def update_field_position(
self,