calvin.erfmann/TagStudio
1
0
Fork 0
mirror of https://github.com/TagStudioDev/TagStudio.git synced 2026-07-25 14:54:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: allow set_version to fail, but don't commit in that case

Browse Source
This commit is contained in:
Jann Stute
2026-07-23 22:24:19 +02:00
parent 75c586db79
commit 200a285de6
1 changed files with 20 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/tagstudio/core/library/alchemy/migrations.py
+20 -11
View File
@@ -118,13 +118,13 @@ class DBMigrations:
MigrationTo202, # changes: tag_parents
MigrationTo300, # changes: deletes folders
]
for migration in migrations:
if self.loaded_db_version < migration.version and (
migration.initial_version is None
or self.initial_db_version < migration.initial_version
):
logger.info(f"[Library][Migration][{migration.version}] Starting DB Migration")
with Session(self.engine) as session:
with Session(self.engine) as session:
for migration in migrations:
if self.loaded_db_version < migration.version and (
migration.initial_version is None
or self.initial_db_version < migration.initial_version
):
logger.info(f"[Library][Migration][{migration.version}] Starting DB Migration")
# any error causes transaction to rollback
migration.run(
session,
@@ -132,8 +132,17 @@ class DBMigrations:
lambda msg, v=migration.version: f"[Library][Migration][{v}] {msg}",
)
self.loaded_db_version = migration.version
Library._set_version(session, DB_VERSION_CURRENT_KEY, migration.version)
session.commit()
try:
Library._set_version(session, DB_VERSION_CURRENT_KEY, migration.version)
except Exception as e:
logger.info(
f"[Library][Migration][{migration.version}] "
"Couldn't update version, continuing without commit",
error=e,
)
session.flush()
else:
session.commit()
logger.info(f"[Library][Migration][{migration.version}] Completed DB Migration")
assert self.loaded_db_version >= DB_VERSION, (
@@ -264,8 +273,8 @@ class MigrationTo101(DBMigration):
text("""
CREATE TABLE versions (
"key" VARCHAR NOT NULL PRIMARY KEY,
value INTEGER NOT NULL,
);
value INTEGER NOT NULL
)
""")
)
session.flush()