mirror of
https://github.com/fosrl/pangolin.git
synced 2026-06-22 15:22:12 +00:00
better-sqlite3 11.x exposes no Statement.finalize() — the wrapper threw and swallowed a TypeError on every query (verified: 'Statement.finalize exists: undefined' in the runner image) while adding +122% per-statement overhead (3.90 -> 8.66 us/op, 200k-op in-container microbench) and freeing nothing. Statement lifecycle is GC-managed by the driver; drizzle-orm prepares fresh per query, so nothing accumulates unbounded. busy_timeout=5000 duplicates better-sqlite3's default timeout option, which already arms sqlite3_busy_timeout(db, 5000) at open (lib/database.js). With ENABLE_SQLITE_WAL_MODE unset the driver is now runtime-identical to pre-1.18.3 (zero pragmas). The env-gated WAL block stays: journal_mode is sticky in the DB file, so removing it would strand opted-in databases on WAL+synchronous=FULL. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
87 lines
2.9 KiB
TypeScript
87 lines
2.9 KiB
TypeScript
import { drizzle as DrizzleSqlite } from "drizzle-orm/better-sqlite3";
|
|
import Database from "better-sqlite3";
|
|
import * as schema from "./schema/schema";
|
|
import path from "path";
|
|
import fs from "fs";
|
|
import { APP_PATH } from "@server/lib/consts";
|
|
import { existsSync, mkdirSync } from "fs";
|
|
|
|
export const location = path.join(APP_PATH, "db", "db.sqlite");
|
|
export const exists = checkFileExists(location);
|
|
|
|
bootstrapVolume();
|
|
|
|
function createDb() {
|
|
const sqlite = new Database(location);
|
|
|
|
if (process.env.ENABLE_SQLITE_WAL_MODE == "true") {
|
|
// Enable WAL mode — allows concurrent readers + single writer, preventing
|
|
// contention across subsystems (verifySession, Traefik, audit, ping).
|
|
// NOTE: journal_mode persists in the DB file once set; unsetting this
|
|
// env var does NOT revert an existing WAL database.
|
|
sqlite.pragma("journal_mode = WAL");
|
|
// NORMAL sync mode: safe with WAL, reduces write lock hold time.
|
|
sqlite.pragma("synchronous = NORMAL");
|
|
}
|
|
|
|
// No busy_timeout pragma: better-sqlite3 already arms
|
|
// sqlite3_busy_timeout(db, 5000) via its default `timeout` option
|
|
// (lib/database.js), so an explicit pragma is redundant.
|
|
|
|
// Intentionally NOT setting cache_size or mmap_size: a large page cache plus
|
|
// a multi-hundred-MB mmap region inflate RSS and cause page-cache thrashing
|
|
// on small (~1 GB) instances. Leave SQLite on its conservative defaults.
|
|
|
|
// Intentionally NOT wrapping prepare()/statements: better-sqlite3 finalizes
|
|
// sqlite3_stmt in the Statement destructor at GC, and drizzle-orm prepares a
|
|
// fresh statement per query (no statement cache), so statements cannot
|
|
// accumulate. better-sqlite3 11.x exposes no Statement.finalize() at all.
|
|
|
|
return DrizzleSqlite(sqlite, {
|
|
schema
|
|
});
|
|
}
|
|
|
|
export const db = createDb();
|
|
export default db;
|
|
export const primaryDb = db;
|
|
export type Transaction = Parameters<
|
|
Parameters<(typeof db)["transaction"]>[0]
|
|
>[0];
|
|
export const DB_TYPE: "pg" | "sqlite" = "sqlite";
|
|
|
|
function checkFileExists(filePath: string): boolean {
|
|
try {
|
|
fs.accessSync(filePath);
|
|
return true;
|
|
} catch {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
function bootstrapVolume() {
|
|
const appPath = APP_PATH;
|
|
|
|
const dbDir = path.join(appPath, "db");
|
|
const logsDir = path.join(appPath, "logs");
|
|
|
|
// check if the db directory exists and create it if it doesn't
|
|
if (!existsSync(dbDir)) {
|
|
mkdirSync(dbDir, { recursive: true });
|
|
}
|
|
|
|
// check if the logs directory exists and create it if it doesn't
|
|
if (!existsSync(logsDir)) {
|
|
mkdirSync(logsDir, { recursive: true });
|
|
}
|
|
|
|
// THIS IS FOR TRAEFIK; NOT REALLY NEEDED, BUT JUST IN CASE
|
|
|
|
const traefikDir = path.join(appPath, "traefik");
|
|
|
|
// check if the traefik directory exists and create it if it doesn't
|
|
if (!existsSync(traefikDir)) {
|
|
mkdirSync(traefikDir, { recursive: true });
|
|
}
|
|
}
|