Bump the github-actions-dependencies group with 2 updates

Bumps the github-actions-dependencies group with 2 updates: [docker/login-action](https://github.com/docker/login-action) and [actions/stale](https://github.com/actions/stale).


Updates `docker/login-action` from 4.5.1 to 4.6.0
- [Release notes](https://github.com/docker/login-action/releases)
- [Commits](https://github.com/docker/login-action/compare/abd2ef45e78c5afb21d64d4ca52ee8550d9572c7...dbcb813823bdd20940b903addbd779551569679f)

Updates `actions/stale` from 10.4.0 to 11.0.0
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/stale/compare/1e223db275d687790206a7acac4d1a11bd6fe629...4391f3da665fdf50b6810c1a66712fb9ba21aa93)

---
updated-dependencies:
- dependency-name: docker/login-action
  dependency-version: 4.6.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-actions-dependencies
- dependency-name: actions/stale
  dependency-version: 11.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>

.github/workflows/cicd.yml

@@ -77,7 +77,7 @@ jobs:
                   fi
 
             - name: Log in to Docker Hub
-              uses: docker/login-action@abd2ef45e78c5afb21d64d4ca52ee8550d9572c7 # v4.5.1
+              uses: docker/login-action@dbcb813823bdd20940b903addbd779551569679f # v4.6.0
               with:
                   registry: docker.io
                   username: ${{ secrets.DOCKER_HUB_USERNAME }}
@@ -149,7 +149,7 @@ jobs:
                   fi
 
             - name: Log in to Docker Hub
-              uses: docker/login-action@abd2ef45e78c5afb21d64d4ca52ee8550d9572c7 # v4.5.1
+              uses: docker/login-action@dbcb813823bdd20940b903addbd779551569679f # v4.6.0
               with:
                   registry: docker.io
                   username: ${{ secrets.DOCKER_HUB_USERNAME }}
@@ -204,7 +204,7 @@ jobs:
               uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
 
             - name: Log in to Docker Hub
-              uses: docker/login-action@abd2ef45e78c5afb21d64d4ca52ee8550d9572c7 # v4.5.1
+              uses: docker/login-action@dbcb813823bdd20940b903addbd779551569679f # v4.6.0
               with:
                   registry: docker.io
                   username: ${{ secrets.DOCKER_HUB_USERNAME }}
@@ -407,7 +407,7 @@ jobs:
               shell: bash
 
             - name: Login to GitHub Container Registry (for cosign)
-              uses: docker/login-action@abd2ef45e78c5afb21d64d4ca52ee8550d9572c7 # v4.5.1
+              uses: docker/login-action@dbcb813823bdd20940b903addbd779551569679f # v4.6.0
               with:
                 registry: ghcr.io
                 username: ${{ github.actor }}

.github/workflows/stale-bot.yml

@@ -14,7 +14,7 @@ jobs:
   stale:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/stale@1e223db275d687790206a7acac4d1a11bd6fe629 # v10.4.0
+      - uses: actions/stale@4391f3da665fdf50b6810c1a66712fb9ba21aa93 # v11.0.0
         with:
           days-before-stale: 14
           days-before-close: 14

messages/en-US.json

@@ -1804,10 +1804,6 @@
     "alertingRulesBannerDescription": "Each rule ties together what to watch (a site, health check, or resource), when to fire (for example offline or unhealthy), and how to notify your team via email, webhooks, or integrations. Use this list to create, enable, and manage those rules.",
     "alertingHealthChecksBannerTitle": "Monitor Health & Resources",
     "alertingHealthChecksBannerDescription": "Health checks are HTTP or TCP monitors you define once. You can then use them as sources in alert rules so you get notified when a target becomes healthy or unhealthy. Health checks on resources also appear here.",
-    "alertingTestRule": "Test Alert Rule",
-    "alertingNoActionsTitle": "No actions configured",
-    "alertingNoActionsSaveDescription": "Add at least one action so this rule can notify someone when it fires.",
-    "alertingNoActionsTestDescription": "Add at least one action before you can test this rule.",
     "standaloneHcTableTitle": "Health Checks",
     "standaloneHcSearchPlaceholder": "Search health checks…",
     "standaloneHcAddButton": "Create Health Check",

server/auth/actions.ts

@@ -151,7 +151,6 @@ export enum ActionsEnum {
     createAlertRule = "createAlertRule",
     updateAlertRule = "updateAlertRule",
     deleteAlertRule = "deleteAlertRule",
-    testAlertRule = "testAlertRule",
     listAlertRules = "listAlertRules",
     listOrgLabels = "listOrgLabels",
     createOrgLabel = "createOrgLabel",

server/lib/readConfigFile.ts

@@ -258,24 +258,7 @@ export const configSchema = z
                 pp_transport_prefix: z
                     .string()
                     .optional()
-                    .default("pp-transport-v"),
+                    .default("pp-transport-v")
-                rate_limit: z
-                    .object({
-                        average: z
-                            .number()
-                            .positive()
-                            .gt(0)
-                            .optional()
-                            .default(30),
-                        burst: z
-                            .number()
-                            .positive()
-                            .gt(0)
-                            .optional()
-                            .default(50)
-                    })
-                    .optional()
-                    .prefault({})
             })
             .optional()
             .prefault({}),

server/private/lib/alerts/processTestAlerts.ts

@@ -1,73 +0,0 @@
-import logger from "@server/logger";
-import type {
-    EmailAlertAction,
-    TestAlertContext
-} from "@server/routers/alertRule/types";
-import { sendAlertEmail } from "./sendAlertEmail";
-import type { db, alertEmailRecipients, users, userOrgRoles } from "@server/db";
-import type { eq } from "drizzle-orm";
-
-export async function processTestAlerts(context: TestAlertContext) {
-    const emailActions = context.actions.filter(
-        (action) => action.type === "email"
-    );
-    // Process email actions
-    for (const action of emailActions) {
-        try {
-            const recipients = await resolveEmailRecipients(action);
-            if (recipients.length > 0) {
-                await sendAlertEmail(recipients, context);
-            }
-        } catch (err) {
-            logger.error(`processAlerts: failed to send alert email`, err);
-        }
-    }
-}
-
-/**
- * Resolves all email addresses for a given `emailActionId`.
- *
- * Recipients may be:
- * - Direct users (by `userId`)
- * - All users in a role (by `roleId`, resolved via `userOrgRoles`)
- * - Direct external email addresses
- */
-async function resolveEmailRecipients(
-    action: EmailAlertAction
-): Promise<string[]> {
-    const emailSet = new Set<string>();
-
-    // for (const row of rows) {
-    //     if (row.email) {
-    //         emailSet.add(row.email);
-    //     }
-
-    //     if (row.userId) {
-    //         const [user] = await db
-    //             .select({ email: users.email })
-    //             .from(users)
-    //             .where(eq(users.userId, row.userId))
-    //             .limit(1);
-    //         if (user?.email) {
-    //             emailSet.add(user.email);
-    //         }
-    //     }
-
-    //     if (row.roleId) {
-    //         // Find all users with this role via userOrgRoles
-    //         const roleUsers = await db
-    //             .select({ email: users.email })
-    //             .from(userOrgRoles)
-    //             .innerJoin(users, eq(userOrgRoles.userId, users.userId))
-    //             .where(eq(userOrgRoles.roleId, Number(row.roleId)));
-
-    //         for (const u of roleUsers) {
-    //             if (u.email) {
-    //                 emailSet.add(u.email);
-    //             }
-    //         }
-    //     }
-    // }
-
-    return Array.from(emailSet);
-}

server/private/lib/traefik/getTraefikConfig.ts

@@ -58,8 +58,6 @@ import { build } from "@server/build";
 const redirectHttpsMiddlewareName = "redirect-to-https";
 const redirectToRootMiddlewareName = "redirect-to-root";
 const badgerMiddlewareName = "badger";
-const landingRateLimitMiddlewareName = "landing-ratelimit";
-const bgRateLimitMiddlewareName = "bg-ratelimit";
 
 // Define extended target type with site information
 type TargetWithSite = Target & {
@@ -420,8 +418,6 @@ export async function getTraefikConfig(
         // logger.debug(`Valid certs for domains: ${JSON.stringify(validCerts)}`);
     }
 
-    const traefikRateLimit = config.getRawConfig().traefik.rate_limit;
-
     const config_output: any = {
         http: {
             middlewares: {
@@ -436,18 +432,6 @@ export async function getTraefikConfig(
                         replacement: "${1}://${2}/auth/org",
                         permanent: false
                     }
-                },
-                [landingRateLimitMiddlewareName]: {
-                    rateLimit: {
-                        average: traefikRateLimit.average,
-                        burst: traefikRateLimit.burst
-                    }
-                },
-                [bgRateLimitMiddlewareName]: {
-                    rateLimit: {
-                        average: traefikRateLimit.average,
-                        burst: traefikRateLimit.burst
-                    }
                 }
             }
         }
@@ -1071,7 +1055,6 @@ export async function getTraefikConfig(
                 config.getRawConfig().traefik.additional_middlewares || [];
             const routerMiddlewares = [
                 badgerMiddlewareName,
-                bgRateLimitMiddlewareName,
                 ...additionalMiddlewares
             ];
 
@@ -1556,7 +1539,6 @@ export async function getTraefikConfig(
                     entryPoints: [
                         config.getRawConfig().traefik.https_entrypoint
                     ],
-                    middlewares: [landingRateLimitMiddlewareName],
                     service: "landing-service",
                     rule: `Host(\`${fullDomain}\`) && (PathRegexp(\`^/auth/resource/[^/]+$\`) || PathRegexp(\`^/auth/idp/[0-9]+/oidc/callback\`) || PathPrefix(\`/_next\`) || Path(\`/auth/org\`) || PathRegexp(\`^/__nextjs*\`) || Path(\`/favicon.ico\`))`,
                     priority: 203,
@@ -1575,10 +1557,7 @@ export async function getTraefikConfig(
                     entryPoints: [
                         config.getRawConfig().traefik.https_entrypoint
                     ],
-                    middlewares: [
+                    middlewares: [redirectToRootMiddlewareName],
-                        landingRateLimitMiddlewareName,
-                        redirectToRootMiddlewareName
-                    ],
                     service: "landing-service",
                     rule: `Host(\`${fullDomain}\`)`,
                     priority: 202,

server/private/routers/alertRule/index.ts

@@ -16,4 +16,3 @@ export * from "./updateAlertRule";
 export * from "./deleteAlertRule";
 export * from "./listAlertRules";
 export * from "./getAlertRule";
-export * from "./testAlertRule";

server/private/routers/alertRule/testAlertRule.ts

@@ -1,107 +0,0 @@
-/*
- * This file is part of a proprietary work.
- *
- * Copyright (c) 2025-2026 Fossorial, Inc.
- * All rights reserved.
- *
- * This file is licensed under the Fossorial Commercial License.
- * You may not use this file except in compliance with the License.
- * Unauthorized use, copying, modification, or distribution is strictly prohibited.
- *
- * This file is not licensed under the AGPLv3.
- */
-
-import { Request, Response, NextFunction } from "express";
-import { z } from "zod";
-import { db } from "@server/db";
-import {
-    alertRules,
-    alertSites,
-    alertHealthChecks,
-    alertResources
-} from "@server/db";
-import response from "@server/lib/response";
-import HttpCode from "@server/types/HttpCode";
-import createHttpError from "http-errors";
-import logger from "@server/logger";
-import { fromError } from "zod-validation-error";
-import { OpenAPITags, registry } from "@server/openApi";
-import { and, asc, desc, eq, inArray, like, or, sql } from "drizzle-orm";
-import { ListAlertRulesResponse } from "@server/routers/alertRule/types";
-
-const paramsSchema = z.strictObject({
-    orgId: z.string().nonempty()
-});
-
-export const SITE_EVENT_TYPES = [
-    "site_online",
-    "site_offline",
-    "site_toggle"
-] as const;
-export const HC_EVENT_TYPES = [
-    "health_check_healthy",
-    "health_check_unhealthy",
-    "health_check_toggle"
-] as const;
-export const RESOURCE_EVENT_TYPES = [
-    "resource_healthy",
-    "resource_unhealthy",
-    "resource_degraded",
-    "resource_toggle"
-] as const;
-
-const webhookActionSchema = z.strictObject({
-    webhookUrl: z.string().url(),
-    config: z.string().optional(),
-    enabled: z.boolean().optional().default(true)
-});
-
-const bodySchema = z.strictObject({
-    eventType: z.enum([
-        ...HC_EVENT_TYPES,
-        ...SITE_EVENT_TYPES,
-        ...RESOURCE_EVENT_TYPES
-    ]),
-    // Email recipients (flat)
-    userIds: z.array(z.string().nonempty()).optional().default([]),
-    roleIds: z.array(z.number()).optional().default([]),
-    emails: z.array(z.email()).optional().default([]),
-    // Webhook actions
-    webhookActions: z.array(webhookActionSchema).optional().default([])
-});
-
-export async function testAlertRule(
-    req: Request,
-    res: Response,
-    next: NextFunction
-): Promise<any> {
-    try {
-        const parsedParams = paramsSchema.safeParse(req.params);
-        if (!parsedParams.success) {
-            return next(
-                createHttpError(
-                    HttpCode.BAD_REQUEST,
-                    fromError(parsedParams.error).toString()
-                )
-            );
-        }
-        const { orgId } = parsedParams.data;
-
-        const parsedBody = bodySchema.safeParse(req.body);
-        if (!parsedBody.success) {
-            return next(
-                createHttpError(
-                    HttpCode.BAD_REQUEST,
-                    fromError(parsedBody.error).toString()
-                )
-            );
-        }
-
-        // TODO: process alert rule
-    } catch (error) {
-        logger.error(error);
-        return next(
-            createHttpError(HttpCode.INTERNAL_SERVER_ERROR, "An error occurred")
-        );
-    }
-}

server/private/routers/certificates/getBatchedCertificates.ts

@@ -10,12 +10,12 @@
  *
  * This file is not licensed under the AGPLv3.
  */
-import { certificates, db, domainNamespaces, domains, orgDomains } from "@server/db";
+import { certificates, db, domains, orgDomains } from "@server/db";
 import response from "@server/lib/response";
 import logger from "@server/logger";
 import { type GetBatchedCertificateResponse } from "@server/routers/certificates/types";
 import HttpCode from "@server/types/HttpCode";
-import { and, eq, inArray, isNotNull, or } from "drizzle-orm";
+import { and, eq, inArray, or } from "drizzle-orm";
 import { NextFunction, Request, Response } from "express";
 import createHttpError from "http-errors";
 import { z } from "zod";
@@ -46,7 +46,7 @@ const getCertificateQuerySchema = z.object({
 
 async function query(orgId: string, domainList: string[]) {
     // Try to get CNAME certificates first
-    const existingCertificates = await db
+    let existingCertificates = await db
         .select({
             certId: certificates.certId,
             domain: certificates.domain,
@@ -63,43 +63,26 @@ async function query(orgId: string, domainList: string[]) {
         })
         .from(certificates)
         .innerJoin(domains, eq(certificates.domainId, domains.domainId))
-        .leftJoin(
+        .innerJoin(
             orgDomains,
             and(
                 eq(domains.domainId, orgDomains.domainId),
                 eq(orgDomains.orgId, orgId)
             )
         )
-        .leftJoin(
+        .where(and(inArray(certificates.domain, domainList)));
-            domainNamespaces,
-            eq(domains.domainId, domainNamespaces.domainId)
-        )
-        .where(
-            and(
-                inArray(certificates.domain, domainList),
-                // Namespace domains are shared across all orgs, so they skip
-                // the org-ownership check (mirrors verifyCertificateAccess).
-                or(
-                    isNotNull(orgDomains.orgId),
-                    isNotNull(domainNamespaces.domainNamespaceId)
-                )
-            )
-        );
 
     // All non resolved domain certificates might be `ns` or `wildcard`,
-    // which means exact domain certificates do not exist
+    // which means exact domain certificates do not
-    const foundDomains = new Set(
+    const nonAvailableCertificates = existingCertificates
-        existingCertificates.map((cert) => cert.domain)
+        .filter((cert) => !domainList.includes(cert.domain))
-    );
+        .map((cert) => cert.domain);
-    const domainsWithMissingCertificates = domainList.filter(
-        (domain) => !foundDomains.has(domain)
-    );
 
-    if (domainsWithMissingCertificates.length > 0) {
+    if (nonAvailableCertificates.length > 0) {
         const domainLevelDownSet = new Set<string>();
         const wildcardDomainSet = new Set<string>();
 
-        for (const domain of domainsWithMissingCertificates) {
+        for (const domain of nonAvailableCertificates) {
             const domainLevelDown = domain.split(".").slice(1).join(".");
             const wildcardPrefixed = `*.${domainLevelDown}`;
             domainLevelDownSet.add(domainLevelDown);
@@ -124,27 +107,19 @@ async function query(orgId: string, domainList: string[]) {
             })
             .from(certificates)
             .innerJoin(domains, eq(certificates.domainId, domains.domainId))
-            .leftJoin(
+            .innerJoin(
                 orgDomains,
                 and(
                     eq(domains.domainId, orgDomains.domainId),
                     eq(orgDomains.orgId, orgId)
                 )
             )
-            .leftJoin(
-                domainNamespaces,
-                eq(domains.domainId, domainNamespaces.domainId)
-            )
             .where(
                 and(
                     eq(certificates.wildcard, true),
                     or(
                         inArray(certificates.domain, [...domainLevelDownSet]),
                         inArray(certificates.domain, [...wildcardDomainSet])
-                    ),
-                    or(
-                        isNotNull(orgDomains.orgId),
-                        isNotNull(domainNamespaces.domainNamespaceId)
                     )
                 )
             );
@@ -156,7 +131,6 @@ async function query(orgId: string, domainList: string[]) {
     for (const domain of domainList) {
         const domainLevelDown = domain.split(".").slice(1).join(".");
         const wildcardPrefixed = `*.${domainLevelDown}`;
-
         certificateMap[domain] =
             existingCertificates.find(
                 (cert) =>

server/private/routers/external.ts

@@ -808,14 +808,6 @@ authenticated.get(
     alertRule.listAlertRules
 );
 
-authenticated.post(
-    "/org/:orgId/alert-rule/test",
-    verifyValidLicense,
-    verifyOrgAccess,
-    verifyUserHasAction(ActionsEnum.testAlertRule),
-    alertRule.testAlertRule
-);
-
 authenticated.get(
     "/org/:orgId/alert-rule/:alertRuleId",
     verifyValidLicense,

server/routers/alertRule/types.ts

@@ -124,26 +124,3 @@ export interface AlertContext {
     /** Human-readable context data included in emails and webhook payloads */
     data: Record<string, unknown>;
 }
-
-export type EmailAlertAction = {
-    type: "email";
-    userIds?: string[];
-    roleIds?: string[];
-    emails?: string[];
-};
-
-export type WebhookAlertAction = {
-    type: "webhook";
-    webhookUrl: string;
-    enabled: boolean;
-    config?: string | undefined;
-};
-
-type AlertAction = EmailAlertAction | WebhookAlertAction;
-export interface TestAlertContext {
-    eventType: AlertEventType;
-    actions: AlertAction[];
-    orgId: string;
-    /** Human-readable context data included in emails and webhook payloads */
-    data: Record<string, unknown>;
-}

server/routers/badger/verifySession.ts

@@ -127,9 +127,6 @@ export async function verifyResourceSession(
         // Extract HTTP Basic Auth credentials if present
         const clientHeaderAuth = extractBasicAuth(headers);
 
-        const clientUserAgent = headers?.["user-agent"] || headers?.["User-Agent"];
-        const clientIsBrowser = isBrowserUserAgent(clientUserAgent);
-
         const clientIp = requestIp
             ? stripPortFromHost(requestIp, badgerVersion)
             : undefined;
@@ -316,14 +313,9 @@ export async function verifyResourceSession(
             return allowed(res, undefined, dontStripSession);
         }
 
-        // Only offer a browser redirect to clients that can actually follow one and log in
+        const redirectPath = `/auth/resource/${encodeURIComponent(
-        // (an interactive browser). Non-browser clients (curl, scripts, bots, etc.) just get
-        // an unauthorized response from Badger instead of a login redirect URL.
-        const redirectPath = clientIsBrowser
-            ? `/auth/resource/${encodeURIComponent(
             resource.resourceGuid
-              )}?redirect=${encodeURIComponent(originalRequestURL)}`
+        )}?redirect=${encodeURIComponent(originalRequestURL)}`;
-            : undefined;
 
         // check for access token in headers
         if (
@@ -1484,46 +1476,6 @@ async function getCountryCodeFromIp(ip: string): Promise<string | undefined> {
     return cachedCountryCode;
 }
 
-// Permissive by default: only reject known non-browser clients or a missing
-// User-Agent (real browsers always send one). This avoids blocking real
-// browsers whose UA string doesn't match a hardcoded allow-list.
-const NON_BROWSER_USER_AGENT_PATTERNS = [
-    /curl/,
-    /wget/,
-    /python-requests/,
-    /python-urllib/,
-    /go-http-client/,
-    /okhttp/,
-    /axios/,
-    /node-fetch/,
-    /postmanruntime/,
-    /insomnia/,
-    /libwww-perl/,
-    /java\//,
-    /ruby/,
-    /php/,
-    /bot/,
-    /spider/,
-    /crawler/,
-    /headlesschrome/,
-    /phantomjs/,
-    /httpclient/,
-    /prometheus/,
-    /go-resty/,
-    /apache-httpclient/,
-    /scrapy/
-];
-
-function isBrowserUserAgent(userAgent: string | undefined): boolean {
-    if (!userAgent) {
-        return false;
-    }
-
-    const ua = userAgent.toLowerCase();
-
-    return !NON_BROWSER_USER_AGENT_PATTERNS.some((pattern) => pattern.test(ua));
-}
-
 function extractBasicAuth(
     headers: Record<string, string> | undefined
 ): string | undefined {

server/routers/client/listUserDevices.ts

@@ -67,12 +67,12 @@ const listUserDevicesSchema = z.strictObject({
         }),
     query: z.string().optional(),
     sort_by: z
-        .enum(["megabytesIn", "megabytesOut", "firstSeen", "lastSeen"])
+        .enum(["megabytesIn", "megabytesOut"])
         .optional()
         .catch(undefined)
         .openapi({
             type: "string",
-            enum: ["megabytesIn", "megabytesOut", "firstSeen", "lastSeen"],
+            enum: ["megabytesIn", "megabytesOut"],
             description: "Field to sort by"
         }),
     order: z
@@ -183,9 +183,7 @@ function queryUserDevicesBase() {
             fingerprintArch: currentFingerprint.arch,
             fingerprintSerialNumber: currentFingerprint.serialNumber,
             fingerprintUsername: currentFingerprint.username,
-            fingerprintHostname: currentFingerprint.hostname,
+            fingerprintHostname: currentFingerprint.hostname
-            firstSeen: currentFingerprint.firstSeen,
-            lastSeen: currentFingerprint.lastSeen
         })
         .from(clients)
         .leftJoin(orgs, eq(clients.orgId, orgs.orgId))
@@ -391,23 +389,14 @@ export async function listUserDevices(
 
         const countQuery = db.$count(baseQuery.as("filtered_clients"));
 
-        const sortColumn =
-            sort_by === "firstSeen"
-                ? currentFingerprint.firstSeen
-                : sort_by === "lastSeen"
-                  ? currentFingerprint.lastSeen
-                  : sort_by
-                    ? clients[sort_by]
-                    : undefined;
-
         const listDevicesQuery = baseQuery
             .limit(pageSize)
             .offset(pageSize * (page - 1))
             .orderBy(
-                sortColumn
+                sort_by
                     ? order === "asc"
-                        ? asc(sortColumn)
+                        ? asc(clients[sort_by])
-                        : desc(sortColumn)
+                        : desc(clients[sort_by])
                     : asc(clients.clientId)
             );
 

server/routers/gerbil/updateHolePunch.ts

@@ -112,9 +112,7 @@ export async function updateHolePunch(
             destinations: destinations
         });
     } catch (error) {
-        if (!(error instanceof Error && error.message === "Exit node not allowed")) {
         logger.error(error);
-        }
         return next(
             createHttpError(
                 HttpCode.INTERNAL_SERVER_ERROR,

server/routers/role/createRole.ts

@@ -34,9 +34,7 @@ const createRoleSchema = z.strictObject({
 export const defaultRoleAllowedActions: ActionsEnum[] = [
     ActionsEnum.getOrg,
     ActionsEnum.getResource,
-    ActionsEnum.listResources,
+    ActionsEnum.listResources
-    ActionsEnum.getSiteResource,
-    ActionsEnum.listSiteResources
 ];
 
 export type CreateRoleBody = z.infer<typeof createRoleSchema>;

server/routers/siteResource/listAllSiteResourcesByOrg.ts

@@ -3,13 +3,11 @@ import {
     DB_TYPE,
     Label,
     SiteResource,
-    roleSiteResources,
     siteNetworks,
     siteResourceLabels,
     siteResources,
     sites,
-    labels,
+    labels
-    userSiteResources
 } from "@server/db";
 import response from "@server/lib/response";
 import logger from "@server/logger";
@@ -325,48 +323,7 @@ export async function listAllSiteResourcesByOrg(
             labels: labelFilter
         } = parsedQuery.data;
 
-        let accessibleSiteResourceIds: number[];
+        const conditions = [and(eq(siteResources.orgId, orgId))];
-        if (req.user) {
-            const accessibleSiteResources = await db
-                .select({
-                    siteResourceId: sql<number>`COALESCE(${userSiteResources.siteResourceId}, ${roleSiteResources.siteResourceId})`
-                })
-                .from(userSiteResources)
-                .fullJoin(
-                    roleSiteResources,
-                    eq(
-                        userSiteResources.siteResourceId,
-                        roleSiteResources.siteResourceId
-                    )
-                )
-                .where(
-                    or(
-                        eq(userSiteResources.userId, req.user.userId),
-                        inArray(
-                            roleSiteResources.roleId,
-                            req.userOrgRoleIds ?? []
-                        )
-                    )
-                );
-            accessibleSiteResourceIds = accessibleSiteResources.map(
-                (row) => row.siteResourceId
-            );
-        } else {
-            const allOrgSiteResources = await db
-                .select({ siteResourceId: siteResources.siteResourceId })
-                .from(siteResources)
-                .where(eq(siteResources.orgId, orgId));
-            accessibleSiteResourceIds = allOrgSiteResources.map(
-                (row) => row.siteResourceId
-            );
-        }
-
-        const conditions = [
-            and(
-                eq(siteResources.orgId, orgId),
-                inArray(siteResources.siteResourceId, accessibleSiteResourceIds)
-            )
-        ];
 
         if (siteId != null) {
             // Keep inner joins here: filtering by a specific site implies the

server/routers/siteResource/listSiteResources.ts

@@ -1,17 +1,11 @@
 import { Request, Response, NextFunction } from "express";
 import { z } from "zod";
-import {
+import { db, networks, siteNetworks } from "@server/db";
-    db,
-    networks,
-    roleSiteResources,
-    siteNetworks,
-    userSiteResources
-} from "@server/db";
 import { siteResources, sites, SiteResource } from "@server/db";
 import response from "@server/lib/response";
 import HttpCode from "@server/types/HttpCode";
 import createHttpError from "http-errors";
-import { and, asc, desc, eq, inArray, or, sql } from "drizzle-orm";
+import { and, asc, desc, eq } from "drizzle-orm";
 import { fromError } from "zod-validation-error";
 import logger from "@server/logger";
 import { OpenAPITags, registry } from "@server/openApi";
@@ -165,47 +159,10 @@ export async function listSiteResources(
             return next(createHttpError(HttpCode.NOT_FOUND, "Site not found"));
         }
 
-        let accessibleSiteResourceIds: number[];
-        if (req.user) {
-            const accessibleSiteResources = await db
-                .select({
-                    siteResourceId: sql<number>`COALESCE(${userSiteResources.siteResourceId}, ${roleSiteResources.siteResourceId})`
-                })
-                .from(userSiteResources)
-                .fullJoin(
-                    roleSiteResources,
-                    eq(
-                        userSiteResources.siteResourceId,
-                        roleSiteResources.siteResourceId
-                    )
-                )
-                .where(
-                    or(
-                        eq(userSiteResources.userId, req.user.userId),
-                        inArray(
-                            roleSiteResources.roleId,
-                            req.userOrgRoleIds ?? []
-                        )
-                    )
-                );
-            accessibleSiteResourceIds = accessibleSiteResources.map(
-                (row) => row.siteResourceId
-            );
-        } else {
-            const allOrgSiteResources = await db
-                .select({ siteResourceId: siteResources.siteResourceId })
-                .from(siteResources)
-                .where(eq(siteResources.orgId, orgId));
-            accessibleSiteResourceIds = allOrgSiteResources.map(
-                (row) => row.siteResourceId
-            );
-        }
-
         // Get site resources by joining networks to siteResources via siteNetworks
         const conditions = [
             eq(siteNetworks.siteId, siteId),
-            eq(siteResources.orgId, orgId),
+            eq(siteResources.orgId, orgId)
-            inArray(siteResources.siteResourceId, accessibleSiteResourceIds)
         ];
 
         if (typeof status !== "undefined") {

server/setup/migrationsPg.ts

@@ -28,7 +28,6 @@ import m19 from "./scriptsPg/1.18.4";
 import m20 from "./scriptsPg/1.19.0";
 import m21 from "./scriptsPg/1.20.0";
 import m22 from "./scriptsPg/1.21.0";
-import m23 from "./scriptsPg/1.21.1";
 
 // THIS CANNOT IMPORT ANYTHING FROM THE SERVER
 // EXCEPT FOR THE DATABASE AND THE SCHEMA
@@ -56,8 +55,7 @@ const migrations = [
     { version: "1.18.4", run: m19 },
     { version: "1.19.0", run: m20 },
     { version: "1.20.0", run: m21 },
-    { version: "1.21.0", run: m22 },
+    { version: "1.21.0", run: m22 }
-    { version: "1.21.1", run: m23 }
     // Add new migrations here as they are created
 ] as {
     version: string;

server/setup/migrationsSqlite.ts

@@ -47,7 +47,6 @@ import m41 from "./scriptsSqlite/1.19.0";
 import m42 from "./scriptsSqlite/1.19.1";
 import m43 from "./scriptsSqlite/1.20.0";
 import m44 from "./scriptsSqlite/1.21.0";
-import m45 from "./scriptsSqlite/1.21.1";
 
 // THIS CANNOT IMPORT ANYTHING FROM THE SERVER
 // EXCEPT FOR THE DATABASE AND THE SCHEMA
@@ -92,8 +91,7 @@ const migrations = [
     { version: "1.19.0", run: m41 },
     { version: "1.19.1", run: m42 },
     { version: "1.20.0", run: m43 },
-    { version: "1.21.0", run: m44 },
+    { version: "1.21.0", run: m44 }
-    { version: "1.21.1", run: m45 }
     // Add new migrations here as they are created
 ] as const;
 

server/setup/scriptsPg/1.21.1.ts

@@ -1,37 +0,0 @@
-import { db } from "@server/db/pg/driver";
-import { sql } from "drizzle-orm";
-
-const version = "1.21.1";
-
-const actionsToGrant = ["getSiteResource", "listSiteResources"] as const;
-
-export default async function migration() {
-    console.log(`Running setup script ${version}...`);
-
-    try {
-        await db.execute(sql`BEGIN`);
-
-        for (const actionId of actionsToGrant) {
-            await db.execute(sql`
-                INSERT INTO "roleActions" ("roleId", "actionId", "orgId")
-                SELECT r."roleId", ${actionId}, r."orgId"
-                FROM "roles" r
-                WHERE COALESCE(r."isAdmin", false) = false
-                  AND NOT EXISTS (
-                    SELECT 1 FROM "roleActions" ra
-                    WHERE ra."roleId" = r."roleId"
-                      AND ra."actionId" = ${actionId}
-                      AND ra."orgId" = r."orgId"
-                  );
-            `);
-        }
-
-        await db.execute(sql`COMMIT`);
-        console.log(`Finished setup script ${version}`);
-    } catch (e) {
-        await db.execute(sql`ROLLBACK`);
-        console.log("Unable to migrate database");
-        console.log(e);
-        throw e;
-    }
-}

server/setup/scriptsSqlite/1.21.1.ts

@@ -1,43 +0,0 @@
-import { APP_PATH } from "@server/lib/consts";
-import Database from "better-sqlite3";
-import path from "path";
-
-const version = "1.21.1";
-
-const actionsToGrant = ["getSiteResource", "listSiteResources"] as const;
-
-export default async function migration() {
-    console.log(`Running setup script ${version}...`);
-
-    const location = path.join(APP_PATH, "db", "db.sqlite");
-    const db = new Database(location);
-
-    try {
-        db.transaction(() => {
-            const insertRoleAction = db.prepare(`
-                INSERT INTO 'roleActions' ("roleId", "actionId", "orgId")
-                SELECT r."roleId", ?, r."orgId"
-                FROM 'roles' r
-                WHERE COALESCE(r."isAdmin", 0) = 0
-                  AND NOT EXISTS (
-                    SELECT 1 FROM 'roleActions' ra
-                    WHERE ra."roleId" = r."roleId"
-                      AND ra."actionId" = ?
-                      AND ra."orgId" = r."orgId"
-                  );
-            `);
-
-            for (const actionId of actionsToGrant) {
-                insertRoleAction.run(actionId, actionId);
-            }
-        })();
-
-        console.log(`Finished setup script ${version}`);
-    } catch (e) {
-        console.log("Unable to migrate database");
-        console.log(e);
-        throw e;
-    } finally {
-        db.close();
-    }
-}

src/app/[orgId]/settings/(private)/remote-exit-nodes/[remoteExitNodeId]/networking/page.tsx

@@ -181,7 +181,7 @@ export default function NetworkingPage() {
                     <SettingsSectionDescription>
                         {t("remoteExitNodeNetworkingDescription")}
                         <a
-                            href="https://docs.pangolin.net/manage/remote-node/backhaul"
+                            href="https://docs.pangolin.net/placeholder"
                             target="_blank"
                             rel="noopener noreferrer"
                             className="text-primary hover:underline inline-flex items-center gap-1"

src/app/[orgId]/settings/clients/user/page.tsx

@@ -104,9 +104,7 @@ export default async function ClientsPage(props: ClientsPageProps) {
             archived: Boolean(client.archived),
             blocked: Boolean(client.blocked),
             approvalState: client.approvalState,
-            fingerprint,
+            fingerprint
-            firstSeen: client.firstSeen ?? null,
-            lastSeen: client.lastSeen ?? null
         };
     };
 

src/app/auth/login/page.tsx

@@ -91,7 +91,6 @@ export default async function Page(props: {
     let loginIdps: LoginFormIDP[] = [];
     let lastUsedIdpForSmartLogin: (LoginFormIDP & { orgId?: string }) | null =
         null;
-
     if (!useSmartLogin) {
         // Load IdPs for DashboardLoginForm (OSS or org-only IdP mode)
         if (build === "oss" || env.app.identityProviderMode !== "org") {
@@ -118,12 +117,12 @@ export default async function Page(props: {
                     `/idp/${persistedData.idpId}`
                 );
 
-                const res = idpRes.data.data;
+                const idp = idpRes.data.data.idp;
 
                 lastUsedIdpForSmartLogin = {
-                    idpId: res.idp.idpId,
+                    idpId: idp.idpId,
-                    name: res.idp.name,
+                    name: idp.name,
-                    variant: res.idpOidcConfig?.variant ?? res.idp.type,
+                    variant: idp.type,
                     orgId: persistedData.orgId,
                     lastUsed: true
                 };

src/components/ContactSalesBanner.tsx

@@ -24,7 +24,6 @@ export function ContactSalesBanner() {
                             <ExternalLink className="size-3.5 shrink-0" />
                         </Link>
                         {" " + t("contactSalesOr") + " "}
-                        <span className="whitespace-nowrap">
                         <Link
                             href="https://pangolin.net/contact"
                             target="_blank"
@@ -36,7 +35,6 @@ export function ContactSalesBanner() {
                         </Link>
                         .
                     </span>
-                    </span>
                 </div>
             </div>
         </div>

src/components/IdpLoginButtons.tsx

@@ -26,14 +26,12 @@ type IdpLoginButtonsProps = {
     idps: LoginFormIDP[];
     redirect?: string;
     orgId?: string;
-    passOrgIdToOidcUrl?: boolean;
 };
 
 export default function IdpLoginButtons({
     idps,
     redirect,
-    orgId,
+    orgId
-    passOrgIdToOidcUrl = true
 }: IdpLoginButtonsProps) {
     const [error, setError] = useState<string | null>(null);
     const t = useTranslations();
@@ -70,13 +68,12 @@ export default function IdpLoginButtons({
 
         let redirectToUrl: string | undefined;
         try {
-            const oidcOrgId = passOrgIdToOidcUrl ? orgId : undefined;
+            console.log("generating", idpId, redirect || "/", orgId);
-            console.log("generating", idpId, redirect || "/", oidcOrgId);
             const safeRedirect = cleanRedirect(redirect || "/");
             const response = await generateOidcUrlProxy(
                 idpId,
                 safeRedirect,
-                oidcOrgId
+                orgId
             );
 
             if (response.error) {
@@ -117,6 +114,7 @@ export default function IdpLoginButtons({
 
             <div className="space-y-4">
                 {params.get("gotoapp") ? (
+                    <>
                         <Button
                             type="button"
                             className="w-full"
@@ -126,13 +124,18 @@ export default function IdpLoginButtons({
                         >
                             {t("continueToApplication")}
                         </Button>
+                    </>
                 ) : (
-                    idps.map((idp) => {
+                    <>
+                        {idps.map((idp) => {
                             const effectiveType =
                                 idp.variant || idp.name.toLowerCase();
 
                             return (
-                            <div className="w-full relative" key={idp.idpId}>
+                                <div
+                                    className="w-full relative"
+                                    key={idp.idpId}
+                                >
                                     <Button
                                         key={idp.idpId}
                                         type="button"
@@ -162,7 +165,8 @@ export default function IdpLoginButtons({
                                     )}
                                 </div>
                             );
-                    })
+                        })}
+                    </>
                 )}
             </div>
         </div>

src/components/IdpTypeIcon.tsx

@@ -23,8 +23,6 @@ export default function IdpTypeIcon({
 }: Props) {
     const effectiveType = (variant || type || "").toLowerCase();
 
-    console.log(`[IdpTypeIcon]`, { effectiveType, variant, type });
-
     let src: string | null = null;
     let defaultAlt = "";
 

src/components/MfaInputForm.tsx

@@ -13,7 +13,7 @@ import {
 import { InputOTP, InputOTPGroup, InputOTPSlot } from "./ui/input-otp";
 import { Alert, AlertDescription } from "@app/components/ui/alert";
 import { useTranslations } from "next-intl";
-import { REGEXP_ONLY_DIGITS_AND_CHARS } from "input-otp";
+import { REGEXP_ONLY_DIGITS } from "input-otp";
 
 const MFA_OTP_INPUT_ID = "mfa-otp-code";
 
@@ -82,11 +82,9 @@ export default function MfaInputForm({
                                             maxLength={6}
                                             {...field}
                                             autoComplete="one-time-code"
-                                            inputMode="text"
+                                            inputMode="numeric"
                                             autoFocus
-                                            pattern={
+                                            pattern={REGEXP_ONLY_DIGITS}
-                                                REGEXP_ONLY_DIGITS_AND_CHARS
-                                            }
                                             onChange={(value: string) => {
                                                 field.onChange(value);
                                                 if (value.length === 6) {

src/components/OrgIdpTable.tsx

@@ -1,6 +1,17 @@
 "use client";
 
-import ConfirmDeleteDialog from "@app/components/ConfirmDeleteDialog";
+import { ColumnDef } from "@tanstack/react-table";
+import { ExtendedColumnDef } from "@app/components/ui/data-table";
+import { IdpDataTable } from "@app/components/OrgIdpDataTable";
+import { Button } from "@app/components/ui/button";
+import {
+    Command,
+    CommandEmpty,
+    CommandGroup,
+    CommandInput,
+    CommandItem,
+    CommandList
+} from "@app/components/ui/command";
 import {
     Credenza,
     CredenzaBody,
@@ -11,42 +22,37 @@ import {
     CredenzaHeader,
     CredenzaTitle
 } from "@app/components/Credenza";
-import { isIdpGlobalModeBannerVisible } from "@app/components/IdpGlobalModeBanner";
-import IdpTypeBadge from "@app/components/IdpTypeBadge";
-import IdpTypeIcon from "@app/components/IdpTypeIcon";
-import { IdpDataTable } from "@app/components/OrgIdpDataTable";
-import { Badge } from "@app/components/ui/badge";
-import { Button } from "@app/components/ui/button";
 import {
-    Command,
+    ArrowRight,
-    CommandEmpty,
+    ArrowUpDown,
-    CommandGroup,
+    MoreHorizontal
-    CommandInput,
+} from "lucide-react";
-    CommandItem,
+import { useMemo, useState } from "react";
-    CommandList
+import ConfirmDeleteDialog from "@app/components/ConfirmDeleteDialog";
-} from "@app/components/ui/command";
+import { toast } from "@app/hooks/useToast";
-import { ExtendedColumnDef } from "@app/components/ui/data-table";
+import { formatAxiosError } from "@app/lib/api";
+import { createApiClient } from "@app/lib/api";
+import { useEnvContext } from "@app/hooks/useEnvContext";
+import { useUserContext } from "@app/hooks/useUserContext";
+import { useRouter } from "next/navigation";
 import {
     DropdownMenu,
     DropdownMenuContent,
     DropdownMenuItem,
     DropdownMenuTrigger
 } from "@app/components/ui/dropdown-menu";
-import { useEnvContext } from "@app/hooks/useEnvContext";
-import { usePaidStatus } from "@app/hooks/usePaidStatus";
-import { toast } from "@app/hooks/useToast";
-import { useUserContext } from "@app/hooks/useUserContext";
-import { createApiClient, formatAxiosError } from "@app/lib/api";
-import { cn } from "@app/lib/cn";
-import { tierMatrix } from "@server/lib/billing/tierMatrix";
-import type { ListUserAdminOrgIdpsResponse } from "@server/routers/orgIdp/types";
-import { useQuery } from "@tanstack/react-query";
-import { ArrowRight, ArrowUpDown, MoreHorizontal } from "lucide-react";
-import { useTranslations } from "next-intl";
 import Link from "next/link";
-import { useRouter } from "next/navigation";
+import { useTranslations } from "next-intl";
-import { useMemo, useState } from "react";
+import IdpTypeBadge from "@app/components/IdpTypeBadge";
+import IdpTypeIcon from "@app/components/IdpTypeIcon";
+import { useQuery } from "@tanstack/react-query";
 import { useDebounce } from "use-debounce";
+import type { ListUserAdminOrgIdpsResponse } from "@server/routers/orgIdp/types";
+import { cn } from "@app/lib/cn";
+import { Badge } from "@app/components/ui/badge";
+import { usePaidStatus } from "@app/hooks/usePaidStatus";
+import { tierMatrix } from "@server/lib/billing/tierMatrix";
+import { isIdpGlobalModeBannerVisible } from "@app/components/IdpGlobalModeBanner";
 
 export type IdpRow = {
     idpId: number;
@@ -477,8 +483,7 @@ export default function IdpTable({ idps, orgId }: Props) {
                                                     {group.name}
                                                 </div>
                                                 <div className="mt-1 flex flex-wrap gap-1">
-                                                    {group.sources.map(
+                                                    {group.sources.map((src) => (
-                                                        (src) => (
                                                         <Badge
                                                             key={src.orgId}
                                                             variant="secondary"
@@ -486,8 +491,7 @@ export default function IdpTable({ idps, orgId }: Props) {
                                                         >
                                                             {src.orgName}
                                                         </Badge>
-                                                        )
+                                                    ))}
-                                                    )}
                                                 </div>
                                             </div>
                                         </CommandItem>

src/components/SmartLoginForm.tsx

@@ -303,7 +303,6 @@ export default function SmartLoginForm({
                             <IdpLoginButtons
                                 idps={[lastUsedIdp]}
                                 orgId={lastUsedIdp.orgId}
-                                passOrgIdToOidcUrl={false}
                                 redirect={redirect}
                             />
                         )}

src/components/UptimeBar.tsx

@@ -134,9 +134,7 @@ export default function UptimeBar({
 
     if (!data) return null;
 
-    const allNoData = data.days.every(
+    const allNoData = data.days.every((d) => d.status === "no_data");
-        (d) => d.status === "no_data" || d.status === "unknown"
-    );
 
     return (
         <div className={cn("space-y-3", className)}>

src/components/UptimeMiniBar.tsx

@@ -124,9 +124,7 @@ export function UptimeMiniBar({
 
     if (!data) return null;
 
-    const allNoData = data.days.every(
+    const allNoData = data.days.every((d) => d.status === "no_data");
-        (d) => d.status === "no_data" || d.status === "unknown"
-    );
 
     return (
         <div className="flex items-center gap-2">

src/components/UserDevicesTable.tsx

@@ -77,8 +77,6 @@ export type ClientRow = {
         username: string | null;
         hostname: string | null;
     } | null;
-    firstSeen: number | null;
-    lastSeen: number | null;
 };
 
 type ClientTableProps = {
@@ -114,9 +112,7 @@ export default function UserDevicesTable({
 
     const defaultUserColumnVisibility = {
         subnet: false,
-        niceId: false,
+        niceId: false
-        firstSeen: false,
-        lastSeen: false
     };
 
     const refreshData = () => {
@@ -625,68 +621,6 @@ export default function UserDevicesTable({
                 accessorKey: "subnet",
                 friendlyName: t("address"),
                 header: () => <span className="px-3">{t("address")}</span>
-            },
-            {
-                accessorKey: "firstSeen",
-                friendlyName: t("firstSeen"),
-                header: () => {
-                    const firstSeenOrder = getSortDirection(
-                        "firstSeen",
-                        searchParams
-                    );
-
-                    const Icon =
-                        firstSeenOrder === "asc"
-                            ? ArrowDown01Icon
-                            : firstSeenOrder === "desc"
-                              ? ArrowUp10Icon
-                              : ChevronsUpDownIcon;
-                    return (
-                        <Button
-                            variant="ghost"
-                            onClick={() => toggleSort("firstSeen")}
-                        >
-                            {t("firstSeen")}
-                            <Icon className="ml-2 h-4 w-4" />
-                        </Button>
-                    );
-                },
-                cell: ({ row }) => {
-                    const firstSeen = row.original.firstSeen;
-                    if (!firstSeen) return "-";
-                    return new Date(firstSeen * 1000).toLocaleString();
-                }
-            },
-            {
-                accessorKey: "lastSeen",
-                friendlyName: t("lastSeen"),
-                header: () => {
-                    const lastSeenOrder = getSortDirection(
-                        "lastSeen",
-                        searchParams
-                    );
-
-                    const Icon =
-                        lastSeenOrder === "asc"
-                            ? ArrowDown01Icon
-                            : lastSeenOrder === "desc"
-                              ? ArrowUp10Icon
-                              : ChevronsUpDownIcon;
-                    return (
-                        <Button
-                            variant="ghost"
-                            onClick={() => toggleSort("lastSeen")}
-                        >
-                            {t("lastSeen")}
-                            <Icon className="ml-2 h-4 w-4" />
-                        </Button>
-                    );
-                },
-                cell: ({ row }) => {
-                    const lastSeen = row.original.lastSeen;
-                    if (!lastSeen) return "-";
-                    return new Date(lastSeen * 1000).toLocaleString();
-                }
             }
         ];
 

src/components/alert-rule-editor/AlertRuleGraphEditor.tsx

@@ -6,9 +6,7 @@ import {
     AlertRuleSourceFields,
     AlertRuleTriggerFields
 } from "@app/components/alert-rule-editor/AlertRuleFields";
-import { PaidFeaturesAlert } from "@app/components/PaidFeaturesAlert";
 import { SettingsContainer } from "@app/components/Settings";
-import { SwitchInput } from "@app/components/SwitchInput";
 import { Button } from "@app/components/ui/button";
 import { Card, CardContent } from "@app/components/ui/card";
 import {
@@ -21,7 +19,6 @@ import {
     FormMessage
 } from "@app/components/ui/form";
 import { Input } from "@app/components/ui/input";
-import { useEnvContext } from "@app/hooks/useEnvContext";
 import { toast } from "@app/hooks/useToast";
 import {
     buildFormSchema,
@@ -30,15 +27,19 @@ import {
     type AlertRuleFormValues
 } from "@app/lib/alertRuleForm";
 import { createApiClient, formatAxiosError } from "@app/lib/api";
-import { zodResolver } from "@hookform/resolvers/zod";
+import { useEnvContext } from "@app/hooks/useEnvContext";
-import { tierMatrix } from "@server/lib/billing/tierMatrix";
 import type { CreateAlertRuleResponse } from "@server/routers/alertRule/types";
 import type { AxiosResponse } from "axios";
-import { Cog, Flag, Zap, ZapIcon } from "lucide-react";
+import { zodResolver } from "@hookform/resolvers/zod";
-import { useTranslations } from "next-intl";
+import { ChevronLeft, Cog, Flag, Zap } from "lucide-react";
+import Link from "next/link";
 import { useRouter } from "next/navigation";
-import { useActionState, useMemo, useTransition, type ReactNode } from "react";
+import { useMemo, useState, type ReactNode } from "react";
 import { useFieldArray, useForm, type Resolver } from "react-hook-form";
+import { useTranslations } from "next-intl";
+import { PaidFeaturesAlert } from "@app/components/PaidFeaturesAlert";
+import { SwitchInput } from "@app/components/SwitchInput";
+import { tierMatrix } from "@server/lib/billing/tierMatrix";
 import { Badge } from "../ui/badge";
 
 const FORM_ID = "alert-rule-form";
@@ -114,6 +115,7 @@ export default function AlertRuleGraphEditor({
     const t = useTranslations();
     const router = useRouter();
     const api = createApiClient(useEnvContext());
+    const [isSaving, setIsSaving] = useState(false);
     const schema = useMemo(() => buildFormSchema(t), [t]);
     const form = useForm<AlertRuleFormValues>({
         resolver: zodResolver(schema) as Resolver<AlertRuleFormValues>,
@@ -125,22 +127,8 @@ export default function AlertRuleGraphEditor({
         name: "actions"
     });
 
-    const saveAlert = async () => {
+    const onSubmit = form.handleSubmit(async (values) => {
-        const isValid = await form.trigger();
+        setIsSaving(true);
-        if (!isValid) {
-            const values = form.getValues();
-            if (values.actions.length === 0) {
-                toast({
-                    variant: "warning",
-                    title: t("alertingNoActionsTitle"),
-                    description: t("alertingNoActionsSaveDescription")
-                });
-            }
-            return;
-        }
-
-        const values = form.getValues();
-
         try {
             const payload = formValuesToApiPayload(values);
             if (isNew) {
@@ -170,37 +158,14 @@ export default function AlertRuleGraphEditor({
                 description: formatAxiosError(e),
                 variant: "destructive"
             });
+        } finally {
+            setIsSaving(false);
         }
-        // const submit = form.handleSubmit(async (values) => {
-
-        // });
-
-        // await submit();
-    };
-
-    const testAlert = async () => {
-        const isValid = await form.trigger();
-        if (!isValid) {
-            const values = form.getValues();
-            if (values.actions.length === 0) {
-                toast({
-                    variant: "warning",
-                    title: t("alertingNoActionsTitle"),
-                    description: t("alertingNoActionsTestDescription")
     });
-            }
-            return;
-        }
-
-        const values = form.getValues();
-    };
-
-    const [, formAction, isSaving] = useActionState(saveAlert, null);
-    const [isTestingAlert, startTransition] = useTransition();
 
     return (
         <Form {...form}>
-            <form id={FORM_ID} action={formAction}>
+            <form id={FORM_ID} onSubmit={onSubmit}>
                 <SettingsContainer>
                     <PaidFeaturesAlert tiers={tierMatrix.alertingRules} />
                     <div className="flex flex-col lg:flex-row gap-6 lg:gap-8 items-start">
@@ -298,7 +263,6 @@ export default function AlertRuleGraphEditor({
                                                 </FormItem>
                                             )}
                                         />
-                                        <div className="flex flex-col items-center w-full gap-3">
                                         <Button
                                             type="submit"
                                             className="w-full"
@@ -307,20 +271,6 @@ export default function AlertRuleGraphEditor({
                                         >
                                             {t("save")}
                                         </Button>
-
-                                            <Button
-                                                type="button"
-                                                variant="outline"
-                                                className="w-full gap-1.5"
-                                                onClick={() =>
-                                                    startTransition(testAlert)
-                                                }
-                                                loading={isTestingAlert}
-                                            >
-                                                {t("alertingTestRule")}
-                                                <ZapIcon className="size-3.5 flex-none" />
-                                            </Button>
-                                        </div>
                                     </fieldset>
                                 </CardContent>
                             </Card>

src/hooks/useCertificate.ts

@@ -111,8 +111,7 @@ export function useCertificate({
     let certError: string | null = null;
     if (restartCert.isError) {
         certError = "Failed to restart";
-    } else if (isError || (!isLoading && data === null)) {
+    } else if (isError) {
-        // Null value means failed to get the certificate
         certError = "Failed";
     }
 

src/lib/queries.ts

@@ -1,10 +1,4 @@
-import type { LauncherQueryFilters } from "@app/lib/launcherSearchParams";
-import { buildLauncherSearchParams } from "@app/lib/launcherSearchParams";
 import { build } from "@server/build";
-import {
-    StatusHistoryResponse,
-    type BatchedStatusHistoryResponse
-} from "@server/lib/statusHistory";
 import type { ListAlertRulesResponse } from "@server/routers/alertRule/types";
 import type { QueryRequestAnalyticsResponse } from "@server/routers/auditLogs";
 import type {
@@ -13,7 +7,6 @@ import type {
     QueryConnectionAuditLogResponse,
     QueryRequestAuditLogResponse
 } from "@server/routers/auditLogs/types";
-import type { GetCertificateResponse } from "@server/routers/certificates/types";
 import type {
     ListClientsResponse,
     ListUserDevicesResponse
@@ -23,30 +16,15 @@ import type {
     ListDomainsResponse
 } from "@server/routers/domain";
 import type { GetDomainResponse } from "@server/routers/domain/getDomain";
-import { ListHealthChecksResponse } from "@server/routers/healthChecks/types";
-import type { ListOrgLabelsResponse } from "@server/routers/labels/types";
 import type {
-    LauncherResource,
-    ListLauncherGroupsResponse,
-    ListLauncherLabelsResponse,
-    ListLauncherResourcesResponse,
-    ListLauncherScaleResponse,
-    ListLauncherSitesResponse,
-    ListLauncherViewsResponse
-} from "@server/routers/launcher/types";
-import type { GetResourcePolicyResponse } from "@server/routers/policy";
-import type {
-    GetResourcePoliciesResponse,
     GetResourceWhitelistResponse,
+    GetResourcePoliciesResponse,
     ListResourceNamesResponse,
+    ListResourcesResponse,
     ListResourceRolesResponse,
     ListResourceRulesResponse,
-    ListResourcesResponse,
     ListResourceUsersResponse
 } from "@server/routers/resource";
-import type { GetResourceResponse } from "@server/routers/resource/getResource";
-import type { GetResourceAuthInfoResponse } from "@server/routers/resource/getResourceAuthInfo";
-import type { ListResourcePoliciesResponse } from "@server/routers/resource/types";
 import type { ListRolesResponse } from "@server/routers/role";
 import type { ListSitesResponse } from "@server/routers/site";
 import type {
@@ -55,7 +33,6 @@ import type {
     ListSiteResourceRolesResponse,
     ListSiteResourceUsersResponse
 } from "@server/routers/siteResource";
-import type { GetSiteResourceResponse } from "@server/routers/siteResource/getSiteResource";
 import type { ListTargetsResponse } from "@server/routers/target";
 import type { ListUsersResponse } from "@server/routers/user";
 import type ResponseT from "@server/types/Response";
@@ -65,12 +42,37 @@ import {
     queryOptions
 } from "@tanstack/react-query";
 import { isAxiosError, type AxiosResponse } from "axios";
-import z from "zod";
+import z, { meta } from "zod";
 import { remote } from "./api";
 import { durationToMs } from "./durationToMs";
+import type { ListOrgLabelsResponse } from "@server/routers/labels/types";
+import { ListHealthChecksResponse } from "@server/routers/healthChecks/types";
+import {
+    StatusHistoryResponse,
+    type BatchedStatusHistoryResponse
+} from "@server/lib/statusHistory";
+import type { ListResourcePoliciesResponse } from "@server/routers/resource/types";
+import type { GetResourcePolicyResponse } from "@server/routers/policy";
+import type {
+    ListLauncherGroupsResponse,
+    ListLauncherLabelsResponse,
+    ListLauncherResourcesResponse,
+    ListLauncherScaleResponse,
+    ListLauncherSitesResponse,
+    ListLauncherViewsResponse,
+    LauncherListQuery,
+    LauncherResource,
+    LauncherViewConfig
+} from "@server/routers/launcher/types";
+import type { GetResourceResponse } from "@server/routers/resource/getResource";
+import type { GetResourceAuthInfoResponse } from "@server/routers/resource/getResourceAuthInfo";
+import type { GetSiteResourceResponse } from "@server/routers/siteResource/getSiteResource";
+import type { LauncherQueryFilters } from "@app/lib/launcherSearchParams";
+import { buildLauncherSearchParams } from "@app/lib/launcherSearchParams";
+import type { GetCertificateResponse } from "@server/routers/certificates/types";
 
-export { buildLauncherSearchParams } from "@app/lib/launcherSearchParams";
 export type { LauncherQueryFilters } from "@app/lib/launcherSearchParams";
+export { buildLauncherSearchParams } from "@app/lib/launcherSearchParams";
 
 export type ProductUpdate = {
     link: string | null;