From fb51f42f3590c6fec725ab4f4b8b1b54898a3c62 Mon Sep 17 00:00:00 2001 From: Fred KISSIE Date: Thu, 15 Jan 2026 01:33:52 +0100 Subject: [PATCH] =?UTF-8?q?=E2=99=BB=EF=B8=8F=20set=20`approval`=20&=20`bl?= =?UTF-8?q?ocked`=20work=20in=20tandem?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../routers/approvals/processPendingApproval.ts | 15 ++++++++++----- server/routers/client/unblockClient.ts | 2 +- 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/server/private/routers/approvals/processPendingApproval.ts b/server/private/routers/approvals/processPendingApproval.ts index 24e0940d..43639dd7 100644 --- a/server/private/routers/approvals/processPendingApproval.ts +++ b/server/private/routers/approvals/processPendingApproval.ts @@ -22,7 +22,7 @@ import { approvals, clients, db, orgs, type Approval } from "@server/db"; import { getOrgTierData } from "@server/lib/billing"; import { TierId } from "@server/lib/billing/tiers"; import response from "@server/lib/response"; -import { and, eq } from "drizzle-orm"; +import { and, eq, type InferInsertModel } from "drizzle-orm"; import type { NextFunction, Request, Response } from "express"; const paramsSchema = z.strictObject({ @@ -112,12 +112,17 @@ export async function processPendingApproval( updatedApproval.type === "user_device" && updatedApproval.clientId ) { + const updateDataBody: Partial> = { + approvalState: updateData.decision + }; + + if (updateData.decision === "denied") { + updateDataBody.blocked = true; + } + await db .update(clients) - .set({ - approvalState: updateData.decision, - blocked: updateData.decision == "denied" - }) + .set(updateDataBody) .where(eq(clients.clientId, updatedApproval.clientId)); } diff --git a/server/routers/client/unblockClient.ts b/server/routers/client/unblockClient.ts index 82b608a2..a16a1030 100644 --- a/server/routers/client/unblockClient.ts +++ b/server/routers/client/unblockClient.ts @@ -71,7 +71,7 @@ export async function unblockClient( // Unblock the client await db .update(clients) - .set({ blocked: false }) + .set({ blocked: false, approvalState: null }) .where(eq(clients.clientId, clientId)); return response(res, {