add placeholder approvals ui

This commit is contained in:
miloschwartz
2026-01-19 21:57:28 -08:00
parent 45ecfcc6bb
commit fb15f8cde6
4 changed files with 166 additions and 3 deletions

View File

@@ -8,6 +8,7 @@ import { getCachedOrg } from "@app/lib/api/getCachedOrg";
import type { ApprovalItem } from "@app/lib/queries";
import OrgProvider from "@app/providers/OrgProvider";
import type { GetOrgResponse } from "@server/routers/org";
import type { ListRolesResponse } from "@server/routers/role";
import type { AxiosResponse } from "axios";
import { getTranslations } from "next-intl/server";
@@ -36,6 +37,21 @@ export default async function ApprovalFeedPage(props: ApprovalFeedPageProps) {
org = orgRes.data.data;
}
// Fetch roles to check if approvals are enabled
let hasApprovalsEnabled = false;
const rolesRes = await internal
.get<AxiosResponse<ListRolesResponse>>(
`/org/${params.orgId}/roles`,
await authCookieHeader()
)
.catch((e) => {});
if (rolesRes && rolesRes.status === 200) {
hasApprovalsEnabled = rolesRes.data.data.roles.some(
(role) => role.requireDeviceApproval === true
);
}
const t = await getTranslations();
return (
@@ -51,7 +67,10 @@ export default async function ApprovalFeedPage(props: ApprovalFeedPageProps) {
<OrgProvider org={org}>
<div className="container mx-auto max-w-12xl">
<ApprovalFeed orgId={params.orgId} />
<ApprovalFeed
orgId={params.orgId}
hasApprovalsEnabled={hasApprovalsEnabled}
/>
</div>
</OrgProvider>
</>

View File

@@ -29,12 +29,17 @@ import {
} from "./ui/select";
import { Separator } from "./ui/separator";
import { InfoPopup } from "./ui/info-popup";
import { ApprovalsEmptyState } from "./ApprovalsEmptyState";
export type ApprovalFeedProps = {
orgId: string;
hasApprovalsEnabled: boolean;
};
export function ApprovalFeed({ orgId }: ApprovalFeedProps) {
export function ApprovalFeed({
orgId,
hasApprovalsEnabled
}: ApprovalFeedProps) {
const searchParams = useSearchParams();
const path = usePathname();
const t = useTranslations();
@@ -51,6 +56,11 @@ export function ApprovalFeed({ orgId }: ApprovalFeedProps) {
const approvals = data?.approvals ?? [];
// Show empty state if no approvals are enabled for any role
if (!hasApprovalsEnabled) {
return <ApprovalsEmptyState orgId={orgId} />;
}
return (
<div className="flex flex-col gap-5">
<Card className="">

View File

@@ -0,0 +1,126 @@
"use client";
import { Button } from "@app/components/ui/button";
import { Card, CardContent } from "@app/components/ui/card";
import {
ShieldCheck,
Check,
Ban,
User,
Settings,
ArrowRight
} from "lucide-react";
import { useTranslations } from "next-intl";
import Link from "next/link";
type ApprovalsEmptyStateProps = {
orgId: string;
};
export function ApprovalsEmptyState({ orgId }: ApprovalsEmptyStateProps) {
const t = useTranslations();
return (
<div className="flex flex-col gap-6">
<Card>
<CardContent className="p-12">
<div className="flex flex-col items-center text-center gap-6 max-w-2xl mx-auto">
<div className="rounded-full bg-primary/10 p-4">
<ShieldCheck className="w-12 h-12 text-primary" />
</div>
<div className="space-y-2">
<h3 className="text-2xl font-semibold">
{t("approvalsEmptyStateTitle")}
</h3>
<p className="text-muted-foreground text-lg">
{t("approvalsEmptyStateDescription")}
</p>
</div>
<div className="w-full space-y-4 mt-4">
<div className="bg-muted/50 rounded-lg p-6 space-y-4 border">
<div className="flex items-start gap-4">
<div className="rounded-lg bg-background p-3 border">
<Settings className="w-5 h-5 text-primary" />
</div>
<div className="flex-1 text-left">
<h4 className="font-semibold mb-1">
{t("approvalsEmptyStateStep1Title")}
</h4>
<p className="text-sm text-muted-foreground">
{t(
"approvalsEmptyStateStep1Description"
)}
</p>
</div>
</div>
<div className="flex items-start gap-4">
<div className="rounded-lg bg-background p-3 border">
<User className="w-5 h-5 text-primary" />
</div>
<div className="flex-1 text-left">
<h4 className="font-semibold mb-1">
{t("approvalsEmptyStateStep2Title")}
</h4>
<p className="text-sm text-muted-foreground">
{t(
"approvalsEmptyStateStep2Description"
)}
</p>
</div>
</div>
</div>
{/* Abstract UI Preview */}
<div className="bg-muted/50 rounded-lg p-6 border">
<div className="space-y-3">
<div className="flex items-center justify-between p-3 bg-background rounded border">
<div className="flex items-center gap-3">
<div className="w-8 h-8 rounded-full bg-primary/10 flex items-center justify-center">
<User className="w-4 h-4 text-primary" />
</div>
<div>
<div className="h-3 w-24 bg-muted-foreground/20 rounded mb-1"></div>
<div className="h-2 w-32 bg-muted-foreground/10 rounded"></div>
</div>
</div>
<div className="flex gap-2">
<div className="h-6 w-16 bg-muted-foreground/10 rounded"></div>
<div className="h-6 w-16 bg-muted-foreground/10 rounded"></div>
</div>
</div>
<div className="flex items-center justify-between p-3 bg-background rounded border">
<div className="flex items-center gap-3">
<div className="w-8 h-8 rounded-full bg-primary/10 flex items-center justify-center">
<User className="w-4 h-4 text-primary" />
</div>
<div>
<div className="h-3 w-24 bg-muted-foreground/20 rounded mb-1"></div>
<div className="h-2 w-32 bg-muted-foreground/10 rounded"></div>
</div>
</div>
<div className="flex gap-2">
<div className="h-6 w-16 bg-green-500/20 rounded flex items-center justify-center">
<Check className="w-3 h-3 text-green-600" />
</div>
<div className="h-6 w-16 bg-muted-foreground/10 rounded"></div>
</div>
</div>
</div>
</div>
</div>
<Link href={`/${orgId}/settings/access/roles`}>
<Button className="gap-2 mt-2">
{t("approvalsEmptyStateButtonText")}
<ArrowRight className="w-4 h-4" />
</Button>
</Link>
</div>
</CardContent>
</Card>
</div>
);
}