From c1b473294e5738ea827e47b68a09c0dc09eebe52 Mon Sep 17 00:00:00 2001 From: Fred KISSIE Date: Fri, 23 Jan 2026 04:54:24 +0100 Subject: [PATCH] =?UTF-8?q?=F0=9F=94=A5=20remove=20useless=20`useEffect`?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../resource-target-address-item.tsx | 39 ++++++------------- 1 file changed, 12 insertions(+), 27 deletions(-) diff --git a/src/components/resource-target-address-item.tsx b/src/components/resource-target-address-item.tsx index 16b07974..3c4cb927 100644 --- a/src/components/resource-target-address-item.tsx +++ b/src/components/resource-target-address-item.tsx @@ -1,26 +1,25 @@ import { cn } from "@app/lib/cn"; +import type { DockerState } from "@app/lib/docker"; import { parseHostTarget } from "@app/lib/parseHostTarget"; import { CaretSortIcon } from "@radix-ui/react-icons"; -import { Popover, PopoverTrigger, PopoverContent } from "./ui/popover"; -import { SelectTrigger, SelectContent, SelectItem, Select } from "./ui/select"; +import type { ListSitesResponse } from "@server/routers/site"; import { type ListTargetsResponse } from "@server/routers/target"; +import type { ArrayElement } from "@server/types/ArrayElement"; +import { CheckIcon } from "lucide-react"; +import { useTranslations } from "next-intl"; +import { ContainersSelector } from "./ContainersSelector"; +import { Button } from "./ui/button"; import { Command, - CommandInput, - CommandList, CommandEmpty, CommandGroup, - CommandItem + CommandInput, + CommandItem, + CommandList } from "./ui/command"; -import { CheckIcon } from "lucide-react"; -import { ContainersSelector } from "./ContainersSelector"; -import type { ListSitesResponse } from "@server/routers/site"; -import type { DockerState } from "@app/lib/docker"; -import { useTranslations } from "next-intl"; -import type { ArrayElement } from "@server/types/ArrayElement"; -import { Button } from "./ui/button"; import { Input } from "./ui/input"; -import { useEffect } from "react"; +import { Popover, PopoverContent, PopoverTrigger } from "./ui/popover"; +import { Select, SelectContent, SelectItem, SelectTrigger } from "./ui/select"; type SiteWithUpdateAvailable = ListSitesResponse["sites"][number]; @@ -67,20 +66,6 @@ export function ResourceTargetAddressItem({ }); }; - useEffect(() => { - console.log("onMount"); - return () => console.log("onUnMount"); - }, []); - - useEffect(() => { - console.log("onChange [sites]", { sites }); - // return () => console.log("onUnMount"); - }, [sites]); - - useEffect(() => { - console.log("onChange [proxyTarget]", { proxyTarget }); - }, [proxyTarget]); - return (