calvin.erfmann/pangolin
1
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-07-09 23:49:47 +02:00
Code Issues Packages Projects Releases Wiki Activity

Sort before inserting

Browse Source
This commit is contained in:
Owen
2026-07-09 10:18:26 -04:00
parent d1d58cf455
commit b6ed762724
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/routers/newt/pingAccumulator.ts
+12 -2
View File
@@ -94,7 +94,13 @@ async function flushSitePingsToDb(): Promise<void> {
const pingsToFlush = new Map(pendingSitePings);
pendingSitePings.clear();
const entries = Array.from(pingsToFlush.entries());
// Sort by id ascending so concurrent writers (other app replicas, or
// unrelated single-row updates elsewhere in the app) always acquire row
// locks in the same order. Without this, overlapping batches/updates
// that touch the same rows in different orders can deadlock each other.
const entries = Array.from(pingsToFlush.entries()).sort(
([a], [b]) => a - b
);
const BATCH_SIZE = 50;
for (let i = 0; i < entries.length; i += BATCH_SIZE) {
@@ -193,7 +199,11 @@ async function flushClientPingsToDb(): Promise<void> {
// ── Flush client pings ─────────────────────────────────────────────
if (pingsToFlush.size > 0) {
const entries = Array.from(pingsToFlush.entries());
// Sort ascending for consistent lock ordering (see note in
// flushSitePingsToDb).
const entries = Array.from(pingsToFlush.entries()).sort(
([a], [b]) => a - b
);
const BATCH_SIZE = 50;
for (let i = 0; i < entries.length; i += BATCH_SIZE) {