diff --git a/server/routers/badger/verifySession.ts b/server/routers/badger/verifySession.ts index 44bc32a5..4921d43f 100644 --- a/server/routers/badger/verifySession.ts +++ b/server/routers/badger/verifySession.ts @@ -196,11 +196,13 @@ export async function verifyResourceSession( // otherwise its undefined and we pass } + // IMPORTANT: ADD NEW AUTH CHECKS HERE OR WHEN TURNING OFF ALL OTHER AUTH METHODS IT WILL JUST PASS if ( !resource.sso && !pincode && !password && - !resource.emailWhitelistEnabled + !resource.emailWhitelistEnabled && + !headerAuth ) { logger.debug("Resource allowed because no auth"); return allowed(res); @@ -295,8 +297,9 @@ export async function verifyResourceSession( } // check for HTTP Basic Auth header + const clientHeaderAuthKey = `headerAuth:${clientHeaderAuth}`; if (headerAuth && clientHeaderAuth) { - if (cache.get(clientHeaderAuth)) { + if (cache.get(clientHeaderAuthKey)) { logger.debug( "Resource allowed because header auth is valid (cached)" ); @@ -307,7 +310,7 @@ export async function verifyResourceSession( headerAuth.headerAuthHash ) ) { - cache.set(clientHeaderAuth, clientHeaderAuth); + cache.set(clientHeaderAuthKey, clientHeaderAuth); logger.debug("Resource allowed because header auth is valid"); return allowed(res); }