From 2becb15916ec4d545eb971c7a221d391ff781b65 Mon Sep 17 00:00:00 2001
From: Owen <owen@txv.io>
Date: Mon, 10 Aug 2026 14:27:17 -0400
Subject: [PATCH] put the budget on the role form

---
 messages/en-US.json              |  2 ++
 src/components/BudgetsEditor.tsx | 31 +++++++++++++++++++++----------
 src/components/RoleForm.tsx      | 29 ++++++++++++++++++++++++++++-
 3 files changed, 51 insertions(+), 11 deletions(-)

diff --git a/messages/en-US.json b/messages/en-US.json
index ec25fde1a..f8619f7da 100644
--- a/messages/en-US.json
+++ b/messages/en-US.json
@@ -1079,6 +1079,8 @@
     "accessRoleErrorNewRequired": "New role is required",
     "accessRoleErrorRemove": "Failed to remove role",
     "accessRoleErrorRemoveDescription": "An error occurred while removing the role.",
+    "accessRoleInferenceBudget": "Inference Budget",
+    "accessRoleInferenceBudgetDescription": "Configure how members of this role restrict AI usage based on spending or token limits",
     "accessRoleName": "Role Name",
     "accessRoleQuestionRemove": "You're about to delete the `{name}` role. You cannot undo this action.",
     "accessRoleRemove": "Remove Role",
diff --git a/src/components/BudgetsEditor.tsx b/src/components/BudgetsEditor.tsx
index 2a8b73022..61a0595b8 100644
--- a/src/components/BudgetsEditor.tsx
+++ b/src/components/BudgetsEditor.tsx
@@ -85,12 +85,14 @@ export function BudgetsEditor({
     scope,
     orgId,
     title,
-    description
+    description,
+    hideCardHeader = false
 }: {
     scope: AiBudgetScope;
     orgId: string;
     title: string;
     description: string;
+    hideCardHeader?: boolean;
 }) {
     const { env } = useEnvContext();
     const api = createApiClient({ env });
@@ -268,15 +270,8 @@ export function BudgetsEditor({
         </Button>
     );
 
-    return (
-        <SettingsSection>
-            <SettingsSectionHeader>
-                <SettingsSectionTitle>{title}</SettingsSectionTitle>
-                <SettingsSectionDescription>
-                    {description}
-                </SettingsSectionDescription>
-            </SettingsSectionHeader>
-
+    const body = (
+        <>
             <SettingsSectionBody>
                 <div className="space-y-4">
                     <Table>
@@ -456,6 +451,22 @@ export function BudgetsEditor({
                     {t("saveSettings")}
                 </Button>
             </SettingsSectionFooter>
+        </>
+    );
+
+    if (hideCardHeader) {
+        return <div className="space-y-4">{body}</div>;
+    }
+
+    return (
+        <SettingsSection>
+            <SettingsSectionHeader>
+                <SettingsSectionTitle>{title}</SettingsSectionTitle>
+                <SettingsSectionDescription>
+                    {description}
+                </SettingsSectionDescription>
+            </SettingsSectionHeader>
+            {body}
         </SettingsSection>
     );
 }
diff --git a/src/components/RoleForm.tsx b/src/components/RoleForm.tsx
index 102aa8e3a..eb34f6aa5 100644
--- a/src/components/RoleForm.tsx
+++ b/src/components/RoleForm.tsx
@@ -35,6 +35,7 @@ import { zodResolver } from "@hookform/resolvers/zod";
 import { HorizontalTabs } from "@app/components/HorizontalTabs";
 import { PaidFeaturesAlert } from "./PaidFeaturesAlert";
 import { CheckboxWithLabel } from "./ui/checkbox";
+import { BudgetsEditor } from "@app/components/BudgetsEditor";
 import { tierMatrix } from "@server/lib/billing/tierMatrix";
 import type { Role } from "@server/db";
 
@@ -333,7 +334,15 @@ export function RoleForm({
                             { title: t("general"), href: "#" },
                             ...(env.flags.disableEnterpriseFeatures
                                 ? []
-                                : [{ title: t("sshAccess"), href: "#" }])
+                                : [{ title: t("sshAccess"), href: "#" }]),
+                            ...(variant === "edit" && role
+                                ? [
+                                      {
+                                          title: t("accessRoleInferenceBudget"),
+                                          href: "#"
+                                      }
+                                  ]
+                                : [])
                         ]}
                     >
                         {/* General tab */}
@@ -635,6 +644,24 @@ export function RoleForm({
                                 />
                             </div>
                         )}
+
+                        {/* Inference Budget tab - only available once the role exists */}
+                        {variant === "edit" && role && (
+                            <div className="space-y-4 mt-4">
+                                <BudgetsEditor
+                                    orgId={role.orgId}
+                                    scope={{
+                                        type: "role",
+                                        id: role.roleId
+                                    }}
+                                    hideCardHeader={true}
+                                    title={t("accessRoleInferenceBudget")}
+                                    description={t(
+                                        "accessRoleInferenceBudgetDescription"
+                                    )}
+                                />
+                            </div>
+                        )}
                     </HorizontalTabs>
                 )}
             </form>