From 19210cbf7dd97f82f4d7a9591098da5cb64a7a9a Mon Sep 17 00:00:00 2001 From: Owen Date: Mon, 13 Oct 2025 14:21:50 -0700 Subject: [PATCH] Hide cname and ns if not using dns --- server/lib/traefik/TraefikConfigManager.ts | 2 +- server/private/lib/readConfigFile.ts | 2 +- server/private/lib/traefik/getTraefikConfig.ts | 4 ++-- .../private/routers/certificates/createCertificate.ts | 2 +- src/components/CreateDomainForm.tsx | 10 +++++----- src/lib/pullEnv.ts | 4 ++-- src/lib/types/env.ts | 2 +- 7 files changed, 13 insertions(+), 13 deletions(-) diff --git a/server/lib/traefik/TraefikConfigManager.ts b/server/lib/traefik/TraefikConfigManager.ts index 4898c4ac..ec4e25f4 100644 --- a/server/lib/traefik/TraefikConfigManager.ts +++ b/server/lib/traefik/TraefikConfigManager.ts @@ -310,7 +310,7 @@ export class TraefikConfigManager { } if ( - process.env.GENERATE_OWN_CERTIFICATES === "true" && + process.env.USE_PANGOLIN_DNS === "true" && build != "oss" ) { // Scan current local certificate state diff --git a/server/private/lib/readConfigFile.ts b/server/private/lib/readConfigFile.ts index 3189960c..6651c1c6 100644 --- a/server/private/lib/readConfigFile.ts +++ b/server/private/lib/readConfigFile.ts @@ -83,7 +83,7 @@ export const privateConfigSchema = z.object({ flags: z .object({ enable_redis: z.boolean().optional().default(false), - generate_own_certificates: z.boolean().optional().default(false) + use_pangolin_dns: z.boolean().optional().default(false) }) .optional() .default({}), diff --git a/server/private/lib/traefik/getTraefikConfig.ts b/server/private/lib/traefik/getTraefikConfig.ts index dffaf807..bce2f37c 100644 --- a/server/private/lib/traefik/getTraefikConfig.ts +++ b/server/private/lib/traefik/getTraefikConfig.ts @@ -234,7 +234,7 @@ export async function getTraefikConfig( } // TODO: for now dont filter it out because if you have multiple domain ids and one is failed it causes all of them to fail - // if (resource.certificateStatus !== "valid" && privateConfig.getRawPrivateConfig().flags.generate_own_certificates) { + // if (resource.certificateStatus !== "valid" && privateConfig.getRawPrivateConfig().flags.use_pangolin_dns) { // logger.debug( // `Resource ${resource.resourceId} has certificate stats ${resource.certificateStats}` // ); @@ -267,7 +267,7 @@ export async function getTraefikConfig( let tls = {}; if ( !privateConfig.getRawPrivateConfig().flags - .generate_own_certificates + .use_pangolin_dns ) { let certResolver: string, preferWildcardCert: boolean; if (!configDomain) { diff --git a/server/private/routers/certificates/createCertificate.ts b/server/private/routers/certificates/createCertificate.ts index 463a7b88..43a3426e 100644 --- a/server/private/routers/certificates/createCertificate.ts +++ b/server/private/routers/certificates/createCertificate.ts @@ -27,7 +27,7 @@ export async function createCertificate( domain: string, trx: Transaction | typeof db ) { - if (!privateConfig.getRawPrivateConfig().flags.generate_own_certificates) { + if (!privateConfig.getRawPrivateConfig().flags.use_pangolin_dns) { return; } diff --git a/src/components/CreateDomainForm.tsx b/src/components/CreateDomainForm.tsx index 77fdea9c..38a4549c 100644 --- a/src/components/CreateDomainForm.tsx +++ b/src/components/CreateDomainForm.tsx @@ -119,6 +119,7 @@ export default function CreateDomainForm({ const t = useTranslations(); const { toast } = useToast(); const { org } = useOrgContext(); + const { env } = useEnvContext(); const form = useForm({ resolver: zodResolver(formSchema), @@ -169,7 +170,7 @@ export default function CreateDomainForm({ }, [domainInputValue]); let domainOptions: any = []; - if (build == "enterprise" || build == "saas") { + if (build != "oss" && env.flags.usePangolinDns) { domainOptions = [ { id: "ns", @@ -182,7 +183,7 @@ export default function CreateDomainForm({ description: t("selectDomainTypeCnameDescription") } ]; - } else if (build == "oss") { + } else { domainOptions = [ { id: "wildcard", @@ -559,8 +560,7 @@ export default function CreateDomainForm({ )} - {build == "saas" || - (build == "enterprise" && ( + {build != "oss" && env.flags.usePangolinDns && ( @@ -572,7 +572,7 @@ export default function CreateDomainForm({ )} - ))} + )} diff --git a/src/lib/pullEnv.ts b/src/lib/pullEnv.ts index c099a3fb..c55f06fe 100644 --- a/src/lib/pullEnv.ts +++ b/src/lib/pullEnv.ts @@ -49,8 +49,8 @@ export function pullEnv(): Env { process.env.FLAGS_ENABLE_CLIENTS === "true" ? true : false, hideSupporterKey: process.env.HIDE_SUPPORTER_KEY === "true" ? true : false, - generateOwnCertificates: - process.env.GENERATE_OWN_CERTIFICATES === "true" + usePangolinDns: + process.env.USE_PANGOLIN_DNS === "true" ? true : false }, diff --git a/src/lib/types/env.ts b/src/lib/types/env.ts index 179d390f..9ded37a0 100644 --- a/src/lib/types/env.ts +++ b/src/lib/types/env.ts @@ -28,7 +28,7 @@ export type Env = { disableBasicWireguardSites: boolean; enableClients: boolean; hideSupporterKey: boolean; - generateOwnCertificates: boolean; + usePangolinDns: boolean; }, branding: { appName?: string;