From 08e9cb862d2f851b0ae86b3854e303417d2ebcb0 Mon Sep 17 00:00:00 2001 From: Owen Date: Mon, 27 Apr 2026 15:38:32 -0700 Subject: [PATCH] Fix deleting resource --- server/routers/resource/deleteResource.ts | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/server/routers/resource/deleteResource.ts b/server/routers/resource/deleteResource.ts index a578c3841..682fd6aa9 100644 --- a/server/routers/resource/deleteResource.ts +++ b/server/routers/resource/deleteResource.ts @@ -52,6 +52,16 @@ export async function deleteResource( .from(targets) .where(eq(targets.resourceId, resourceId)); + const healthChecksToBeRemoved = await db + .select() + .from(targetHealthCheck) + .where( + inArray( + targetHealthCheck.targetId, + targetsToBeRemoved.map((t) => t.targetId) + ) + ); + const [deletedResource] = await db .delete(resources) .where(eq(resources.resourceId, resourceId)) @@ -91,16 +101,11 @@ export async function deleteResource( .where(eq(newts.siteId, site.siteId)) .limit(1); - const [healthCheck] = await db - .select() - .from(targetHealthCheck) - .where(eq(targetHealthCheck.targetId, target.targetId)); - await removeTargets( newt.newtId, // [target], [], // deleting the target from newt causes issues because we cant unbind the port. this needs to be fixed in newt before we can do this - [healthCheck], + healthChecksToBeRemoved, deletedResource.protocol, newt.version );