From eb41ed0eb909858c0af8c8b8b3b08d8e7ed986f6 Mon Sep 17 00:00:00 2001
From: Jann Stute <jann.stute@protonmail.com>
Date: Mon, 6 Jul 2026 15:46:13 +0200
Subject: [PATCH] refactor: move assurance 1 to a proper migration method

Moving the assurance after the migrations 7, 8, 9, and 100 is fine because it doesn't affect those.
---
 src/tagstudio/core/library/alchemy/library.py | 20 ++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

diff --git a/src/tagstudio/core/library/alchemy/library.py b/src/tagstudio/core/library/alchemy/library.py
index 7620a14b..42610ad1 100644
--- a/src/tagstudio/core/library/alchemy/library.py
+++ b/src/tagstudio/core/library/alchemy/library.py
@@ -559,13 +559,6 @@ class Library:
         make_tables(self.engine)
 
         with Session(self.engine) as session:
-            # TODO ASSURANCE 1: reordering
-            # Ensure version rows are present
-            if loaded_db_version < 101:
-                session.add(Version(key=DB_VERSION_INITIAL_KEY, value=100))
-                session.add(Version(key=DB_VERSION_CURRENT_KEY, value=DB_VERSION))
-                session.commit()
-
             # save backup if patches will be applied
             if loaded_db_version < DB_VERSION:
                 self.library_dir = library_dir
@@ -574,6 +567,8 @@ class Library:
 
             # migrate DB step by step from one version to the next
             # TODO: every migration step should either complete sucessfully or be aborted fully
+            #  - the migration steps seem to have try-except cases to catch a previously failed
+            #    migration
             if loaded_db_version < 7:
                 # changes: value_type, tags
                 self.__apply_db7_migration(session)
@@ -586,6 +581,9 @@ class Library:
             if loaded_db_version < 100:
                 # changes: tag_parents
                 self.__apply_db100_migration(session)
+            if loaded_db_version < 101:
+                # changes: versions
+                self.__apply_db101_migration(session)
             if loaded_db_version < 102:
                 # changes: tag_parents
                 self.__apply_db102_migration(session)
@@ -742,6 +740,14 @@ class Library:
             session.commit()
             logger.info("[Library][Migration] Refactored TagParent table")
 
+    def __apply_db101_migration(self, session: Session):
+        """Migrate DB to DB_VERSION 101."""
+        with session:
+            # Ensure version rows are present
+            session.add(Version(key=DB_VERSION_INITIAL_KEY, value=100))
+            session.add(Version(key=DB_VERSION_CURRENT_KEY, value=DB_VERSION))
+            session.commit()
+
     def __apply_db102_migration(self, session: Session):
         """Migrate DB to DB_VERSION 102."""
         with session: