From dcb8ded98717b29068a8d8b9d0dcf0ce0c1fadec Mon Sep 17 00:00:00 2001 From: SupKittyMeow <77246128+SupKittyMeow@users.noreply.github.com> Date: Sat, 31 Aug 2024 16:47:26 -0700 Subject: [PATCH] ui: "open in explorer" action follows os name (#370) * Update item_thumb.py * Update preview_panel.py * Update video_player.py * made it so preview_panel.py uses self.open_explorer_action instead of just normal open_explorer_action --- tagstudio/src/qt/widgets/item_thumb.py | 12 +++++++++++- tagstudio/src/qt/widgets/preview_panel.py | 11 ++++++++++- tagstudio/src/qt/widgets/video_player.py | 12 +++++++++++- 3 files changed, 32 insertions(+), 3 deletions(-) diff --git a/tagstudio/src/qt/widgets/item_thumb.py b/tagstudio/src/qt/widgets/item_thumb.py index 5cd1ea23..eda6196d 100644 --- a/tagstudio/src/qt/widgets/item_thumb.py +++ b/tagstudio/src/qt/widgets/item_thumb.py @@ -4,6 +4,7 @@ import contextlib import logging import os +import platform import time import typing from pathlib import Path @@ -195,7 +196,16 @@ class ItemThumb(FlowWidget): self.opener = FileOpenerHelper("") open_file_action = QAction("Open file", self) open_file_action.triggered.connect(self.opener.open_file) - open_explorer_action = QAction("Open file in explorer", self) + + system = platform.system() + open_explorer_action = QAction( + "Open in explorer", self + ) # Default (mainly going to be for linux) + if system == "Darwin": + open_explorer_action = QAction("Reveal in Finder", self) + elif system == "Windows": + open_explorer_action = QAction("Open in Explorer", self) + open_explorer_action.triggered.connect(self.opener.open_explorer) self.thumb_button.addAction(open_file_action) self.thumb_button.addAction(open_explorer_action) diff --git a/tagstudio/src/qt/widgets/preview_panel.py b/tagstudio/src/qt/widgets/preview_panel.py index 45872471..24cb42ce 100644 --- a/tagstudio/src/qt/widgets/preview_panel.py +++ b/tagstudio/src/qt/widgets/preview_panel.py @@ -4,6 +4,7 @@ import logging from pathlib import Path +import platform import time import typing from datetime import datetime as dt @@ -97,7 +98,15 @@ class PreviewPanel(QWidget): image_layout.setContentsMargins(0, 0, 0, 0) self.open_file_action = QAction("Open file", self) - self.open_explorer_action = QAction("Open file in explorer", self) + + system = platform.system() + self.open_explorer_action = QAction( + "Open in explorer", self + ) # Default (mainly going to be for linux) + if system == "Darwin": + self.open_explorer_action = QAction("Reveal in Finder", self) + elif system == "Windows": + self.open_explorer_action = QAction("Open in Explorer", self) self.preview_img = QPushButtonWrapper() self.preview_img.setMinimumSize(*self.img_button_size) diff --git a/tagstudio/src/qt/widgets/video_player.py b/tagstudio/src/qt/widgets/video_player.py index 6bb86099..c6702df8 100644 --- a/tagstudio/src/qt/widgets/video_player.py +++ b/tagstudio/src/qt/widgets/video_player.py @@ -4,6 +4,7 @@ import logging from pathlib import Path +import platform import typing from PySide6.QtCore import ( @@ -129,7 +130,16 @@ class VideoPlayer(QGraphicsView): open_file_action = QAction("Open file", self) open_file_action.triggered.connect(self.opener.open_file) - open_explorer_action = QAction("Open file in explorer", self) + + system = platform.system() + open_explorer_action = QAction( + "Open in explorer", self + ) # Default (mainly going to be for linux) + if system == "Darwin": + open_explorer_action = QAction("Reveal in Finder", self) + elif system == "Windows": + open_explorer_action = QAction("Open in Explorer", self) + open_explorer_action.triggered.connect(self.opener.open_explorer) self.addAction(open_file_action) self.addAction(open_explorer_action)