From 921a8875de22f7c136316edfb5d3038236414b57 Mon Sep 17 00:00:00 2001 From: SkeleyM <86805089+SkeleyM@users.noreply.github.com> Date: Sat, 25 Jan 2025 01:03:39 +0000 Subject: [PATCH] fix(ui): don't always create tag on enter ( #731) --- tagstudio/src/qt/modals/tag_search.py | 4 +++- tagstudio/src/qt/widgets/preview_panel.py | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tagstudio/src/qt/modals/tag_search.py b/tagstudio/src/qt/modals/tag_search.py index 6b3c21c7..d3506567 100644 --- a/tagstudio/src/qt/modals/tag_search.py +++ b/tagstudio/src/qt/modals/tag_search.py @@ -33,7 +33,7 @@ class TagSearchPanel(PanelWidget): tag_chosen = Signal(int) lib: Library is_initialized: bool = False - first_tag_id: int = None + first_tag_id: int | None = None is_tag_chooser: bool exclude: list[int] @@ -202,10 +202,12 @@ class TagSearchPanel(PanelWidget): results_2.append(tag) results_1.sort(key=lambda tag: len(tag.name)) results_2.sort() + self.first_tag_id = results_1[0].id if len(results_1) > 0 else tag_results[0].id for tag in results_1 + results_2: self.scroll_layout.addWidget(self.__build_row_item_widget(tag)) else: # If query doesnt exist add create button + self.first_tag_id = None c = self.construct_tag_button(query) self.scroll_layout.addWidget(c) self.search_field.setFocus() diff --git a/tagstudio/src/qt/widgets/preview_panel.py b/tagstudio/src/qt/widgets/preview_panel.py index 3c60490f..ef1ff99a 100644 --- a/tagstudio/src/qt/widgets/preview_panel.py +++ b/tagstudio/src/qt/widgets/preview_panel.py @@ -73,7 +73,7 @@ class PreviewPanel(QWidget): self.file_attrs = FileAttributes(library, driver) self.fields = FieldContainers(library, driver) - self.tag_search_panel = TagSearchPanel(self.driver.lib) + self.tag_search_panel = TagSearchPanel(self.driver.lib, is_tag_chooser=True) self.add_tag_modal = PanelModal( self.tag_search_panel, Translations.translate_formatted("tag.add.plural") )