From 583d107cb8ba7964d5aba1eb67fa84a6f7fe24bb Mon Sep 17 00:00:00 2001 From: Travis Abendshien <46939827+CyanVoxel@users.noreply.github.com> Date: Fri, 5 Sep 2025 12:44:51 -0700 Subject: [PATCH] fix: reorder renderer types to fix early false positives (#1093) --- src/tagstudio/qt/widgets/thumb_renderer.py | 32 +++++++++++----------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/src/tagstudio/qt/widgets/thumb_renderer.py b/src/tagstudio/qt/widgets/thumb_renderer.py index 1c5f73d3..cd0db2fb 100644 --- a/src/tagstudio/qt/widgets/thumb_renderer.py +++ b/src/tagstudio/qt/widgets/thumb_renderer.py @@ -1524,8 +1524,23 @@ class ThumbRenderer(QObject): if _filepath and _filepath.is_file(): try: ext: str = _filepath.suffix.lower() if _filepath.suffix else _filepath.stem.lower() - # Images ======================================================= + # Ebooks ======================================================= if MediaCategories.is_ext_in_category( + ext, MediaCategories.EBOOK_TYPES, mime_fallback=True + ): + image = self._epub_cover(_filepath) + # Krita ======================================================== + elif MediaCategories.is_ext_in_category( + ext, MediaCategories.KRITA_TYPES, mime_fallback=True + ): + image = self._krita_thumb(_filepath) + # VTF ========================================================== + elif MediaCategories.is_ext_in_category( + ext, MediaCategories.SOURCE_ENGINE_TYPES, mime_fallback=True + ): + image = self._vtf_thumb(_filepath) + # Images ======================================================= + elif MediaCategories.is_ext_in_category( ext, MediaCategories.IMAGE_TYPES, mime_fallback=True ): # Raw Images ----------------------------------------------- @@ -1552,11 +1567,6 @@ class ThumbRenderer(QObject): # PowerPoint Slideshow elif ext in {".pptx"}: image = self._powerpoint_thumb(_filepath) - # Krita ======================================================== - elif MediaCategories.is_ext_in_category( - ext, MediaCategories.KRITA_TYPES, mime_fallback=True - ): - image = self._krita_thumb(_filepath) # OpenDocument/OpenOffice ====================================== elif MediaCategories.is_ext_in_category( ext, MediaCategories.OPEN_DOCUMENT_TYPES, mime_fallback=True @@ -1590,11 +1600,6 @@ class ThumbRenderer(QObject): savable_media_type = False if image is not None: image = self._apply_overlay_color(image, UiColor.GREEN) - # Ebooks ======================================================= - elif MediaCategories.is_ext_in_category( - ext, MediaCategories.EBOOK_TYPES, mime_fallback=True - ): - image = self._epub_cover(_filepath) # Blender ====================================================== elif MediaCategories.is_ext_in_category( ext, MediaCategories.BLENDER_TYPES, mime_fallback=True @@ -1605,11 +1610,6 @@ class ThumbRenderer(QObject): ext, MediaCategories.PDF_TYPES, mime_fallback=True ): image = self._pdf_thumb(_filepath, adj_size) - # VTF ========================================================== - elif MediaCategories.is_ext_in_category( - ext, MediaCategories.SOURCE_ENGINE_TYPES, mime_fallback=True - ): - image = self._vtf_thumb(_filepath) # No Rendered Thumbnail ======================================== if not image: raise NoRendererError