From 2a836b0d25b01c354b34f529f06e63644409fb84 Mon Sep 17 00:00:00 2001 From: Jann Stute <46534683+Computerdores@users.noreply.github.com> Date: Sun, 19 Jan 2025 22:07:40 +0100 Subject: [PATCH] docs: discourage force-pushes on prs that are open for review (#714) * Update CONTRIBUTING.md * Update CONTRIBUTING.md --- CONTRIBUTING.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 5c1ab5e4..6075b3f0 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -157,6 +157,11 @@ Most of the style guidelines can be checked, fixed, and enforced via Ruff. Older - Pull requests should have an adequate title and description which clearly outline your intentions and changes/additions. Feel free to provide screenshots, GIFs, or videos, especially for UI changes. - Pull requests should ideally be limited to **a single** feature or fix. +> [!IMPORTANT] +> Please do not force push if your PR is open for review! +> +> Force pushing makes it impossible to discern which changes have already been reviewed and which haven't. This means a reviewer will then have to rereview all the already reviewed code, which is a lot of unnecessary work for reviewers. + > [!TIP] > If you're unsure where to stop the scope of your PR, ask yourself: _"If I broke this up, could any parts of it still be used by the project in the meantime?"_